Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip duplicated URLs when gathering deps #591

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

TahaAttari
Copy link
Collaborator

@TahaAttari TahaAttari commented Nov 15, 2024

@TahaAttari TahaAttari changed the title [APHL-1288] skip duplicated URLs Skip duplicated URLs when gathering deps Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

Formatting check succeeded!

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.46%. Comparing base (e2684aa) to head (b095c83).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #591   +/-   ##
=========================================
  Coverage     73.45%   73.46%           
  Complexity       19       19           
=========================================
  Files           365      365           
  Lines         19591    19597    +6     
  Branches       2985     2987    +2     
=========================================
+ Hits          14390    14396    +6     
  Misses         3763     3763           
  Partials       1438     1438           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 18, 2024

Copy link
Collaborator

@sliver007 sliver007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Checks pass.

@sliver007 sliver007 merged commit b578062 into master Nov 18, 2024
8 checks passed
@sliver007 sliver007 deleted the aphl-1288-release-optimization branch November 18, 2024 15:16
barhodes added a commit that referenced this pull request Nov 18, 2024
* Move visitors to cr package and fix warnings

* Fix issues with recursive gather

* Fix adapter visit tests

* fix merge issues

* Skip duplicated URLs when gathering deps (#591)

* [APHL-1288] skip duplicated URLs

Co-authored-by: taha.attari@smilecdr.com <taha.attari@smilecdr.com>

* fix case statements

* get latest should be last not first element (#584)

Co-authored-by: taha.attari@smilecdr.com <taha.attari@smilecdr.com>
Co-authored-by: Adam Stevenson <stevenson_adam@yahoo.com>

* Move visitors to cr package and fix warnings

* Fix issues with recursive gather

* Fix adapter visit tests

* fix merge issues

* fix case statements

* cleanup

* remove orphans

---------

Co-authored-by: Taha <TahaAttari@users.noreply.github.com>
Co-authored-by: taha.attari@smilecdr.com <taha.attari@smilecdr.com>
Co-authored-by: Adam Stevenson <stevenson_adam@yahoo.com>
TahaAttari added a commit that referenced this pull request Nov 19, 2024
* [APHL-1288] skip duplicated URLs

Co-authored-by: taha.attari@smilecdr.com <taha.attari@smilecdr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants