Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin Conventions Plugin #1438

Merged
merged 26 commits into from
Nov 18, 2024
Merged

Kotlin Conventions Plugin #1438

merged 26 commits into from
Nov 18, 2024

Conversation

JPercival
Copy link
Contributor

  • Add formatting and static analysis checks for Kotlin code
  • Convert a couple sample classes to Kotlin to ensure conventions work

Copy link

github-actions bot commented Nov 6, 2024

Formatting check succeeded!

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 61.66667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 64.37%. Comparing base (935ef51) to head (b70a127).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ramework/cql/elm/visiting/BaseElmLibraryVisitor.kt 74.00% 0 Missing and 13 partials ⚠️
...l/src/main/java/org/cqframework/cql/Application.kt 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1438      +/-   ##
============================================
+ Coverage     64.35%   64.37%   +0.01%     
- Complexity     1920     1935      +15     
============================================
  Files           494      494              
  Lines         28131    28102      -29     
  Branches       5588     5561      -27     
============================================
- Hits          18105    18091      -14     
+ Misses         7773     7767       -6     
+ Partials       2253     2244       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Kotlin looks nice!

I found one issue related to the CLI application, but it has an easy fix. See my individual comment on the Application.kt file.

Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and the CQL CLI now runs as expected. Thanks!

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit cc340a3 into master Nov 18, 2024
7 of 8 checks passed
@JPercival JPercival deleted the feature-kotlin-conventions branch November 18, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants