-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin Conventions Plugin #1438
Conversation
JPercival
commented
Nov 6, 2024
- Add formatting and static analysis checks for Kotlin code
- Convert a couple sample classes to Kotlin to ensure conventions work
* small cleanup * fix the jvm toolchain version --------- Co-authored-by: Anton Vasetenkov <antvaset@gmail.com>
Formatting check succeeded! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1438 +/- ##
============================================
+ Coverage 64.35% 64.37% +0.01%
- Complexity 1920 1935 +15
============================================
Files 494 494
Lines 28131 28102 -29
Branches 5588 5561 -27
============================================
- Hits 18105 18091 -14
+ Misses 7773 7767 -6
+ Partials 2253 2244 -9 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Kotlin looks nice!
I found one issue related to the CLI application, but it has an easy fix. See my individual comment on the Application.kt
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and the CQL CLI now runs as expected. Thanks!
|