Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of Model hierarchy to Kotlin #1457

Merged
merged 14 commits into from
Dec 2, 2024

Conversation

JPercival
Copy link
Contributor

@JPercival JPercival commented Nov 27, 2024

  • Converted the rest of the cql2elm.model package to Kotlin
  • Removed dead paths for exception handling
  • Fixed some null pointer exceptions resulting from stricter null handling

Copy link

github-actions bot commented Nov 27, 2024

Formatting check succeeded!

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 70.11834% with 404 lines in your changes missing coverage. Please review.

Project coverage is 66.01%. Comparing base (e9b4887) to head (c2e7b8b).
Report is 1 commits behind head on feature-kotlin.

Files with missing lines Patch % Lines
...org/cqframework/cql/cql2elm/model/ModelImporter.kt 54.80% 125 Missing and 35 partials ⚠️
...work/cql/cql2elm/model/InstantiationContextImpl.kt 49.33% 66 Missing and 10 partials ⚠️
...org/cqframework/cql/cql2elm/model/ConversionMap.kt 72.52% 44 Missing and 17 partials ⚠️
...g/cqframework/cql/cql2elm/model/CompiledLibrary.kt 70.16% 27 Missing and 10 partials ⚠️
...org/cqframework/cql/cql2elm/model/OperatorEntry.kt 85.78% 19 Missing and 9 partials ⚠️
...ork/cql/cql2elm/model/ResolvedIdentifierContext.kt 65.00% 10 Missing and 4 partials ⚠️
...in/java/org/cqframework/cql/cql2elm/model/Model.kt 83.01% 4 Missing and 5 partials ⚠️
...va/org/cqframework/cql/cql2elm/model/Conversion.kt 90.00% 2 Missing and 5 partials ⚠️
...va/org/cqframework/cql/cql2elm/LibraryBuilder.java 78.57% 2 Missing and 1 partial ⚠️
...lm/preprocessor/CqlPreprocessorElmCommonVisitor.kt 57.14% 0 Missing and 3 partials ⚠️
... and 3 more
Additional details and impacted files
@@                 Coverage Diff                  @@
##             feature-kotlin    #1457      +/-   ##
====================================================
+ Coverage             65.86%   66.01%   +0.15%     
- Complexity             2438     2755     +317     
====================================================
  Files                   487      487              
  Lines                 28599    28447     -152     
  Branches               5497     5459      -38     
====================================================
- Hits                  18836    18780      -56     
+ Misses                 7536     7476      -60     
+ Partials               2227     2191      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival marked this pull request as ready for review November 29, 2024 15:13
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
72.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival requested a review from antvaset December 1, 2024 03:58
@JPercival JPercival changed the base branch from master to feature-kotlin December 2, 2024 16:15
@JPercival JPercival merged commit 85d3453 into feature-kotlin Dec 2, 2024
7 of 8 checks passed
@JPercival JPercival deleted the feature-model-kotlin-wip branch December 2, 2024 16:16
@JPercival JPercival restored the feature-model-kotlin-wip branch December 7, 2024 04:36
@JPercival JPercival deleted the feature-model-kotlin-wip branch December 7, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants