Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support expires_in as a string #122

Closed
brynrhodes opened this issue Jun 24, 2019 · 1 comment
Closed

Support expires_in as a string #122

brynrhodes opened this issue Jun 24, 2019 · 1 comment
Assignees
@c-schuler
Labels
cds-hooks Cds-hooks implementation enhancement New feature or request

Comments

@brynrhodes
Copy link
Member

Although the CDS Hooks release 1.0 specification indicates that the expires_in element of the fhirAuthorization object in a request is an integer, some systems communicate this as the string representation of an integer value. Add support for handling expires_in as either an integer, or the string representation of an integer. Either way, the value is expected to be a number of seconds.
@brynrhodes brynrhodes added the enhancement New feature or request label Jun 24, 2019
@c-schuler c-schuler self-assigned this Jun 24, 2019
c-schuler pushed a commit that referenced this issue Jun 24, 2019
#122: Making expires_in cds hooks request value to accept String and …
7d23bc8 
…integer values
c-schuler pushed a commit that referenced this issue Jun 24, 2019
#122: making improvement to last commit
eb683cc
@JPercival JPercival added the cds-hooks Cds-hooks implementation label Feb 22, 2022
@JPercival JPercival added the 1 label Sep 20, 2022
c-schuler added a commit that referenced this issue Sep 21, 2022
@c-schuler
#122 - adding expires_in as string support for cds hooks requests ...…
1e62825 
… added simple test
@c-schuler c-schuler mentioned this issue Sep 21, 2022
Merged
JPercival pushed a commit that referenced this issue Sep 22, 2022
@c-schuler
Support for expires_in as string (#614)
2539ad6 
#122 - adding expires_in as string support for cds hooks requests ... added simple test
@c-schuler
Copy link
Contributor

Resolved in PR #614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c-schuler c-schuler

Labels
cds-hooks Cds-hooks implementation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brynrhodes @JPercival @c-schuler