Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$ra.resolve should error if approve has not been called first #670

Closed
rob-reynolds opened this issue Nov 27, 2022 · 0 comments
Closed

$ra.resolve should error if approve has not been called first #670

rob-reynolds opened this issue Nov 27, 2022 · 0 comments
Assignees
@c-schuler
Labels
bug Something isn't working

Comments

@rob-reynolds
Copy link

rob-reynolds commented Nov 27, 2022 •
edited
Loading

As a Payer, I need resolve to fail if the CC Coder hasn't run approve.

IS: running resolve completes even if approve has not been run

SHOULD BE: should require approve (i.e., all the most recent DI resources are status = final)

REPRO:

  • clone the DaVinci Risk Adjustment IG locally (https://github.com/HL7/davinci-ra/)
  • open the RA IG in VS Code
  • open the Thunder Client plugin
    • in Env, set the Risk Adjustment.RAServer variable to the Public Endpoint value
  • run everything in the $ra.coding-gaps folder
  • run everything in the $ra.remediate-coding-gaps folder
  • run everything in the $ra.resolve-coding-gaps folder
  • note that running the $ra.resolve-coding-gaps request does not error (even though approve has not been run)

ACCEPTANCE CRITERIA:

  • in the scenario above the resolve operation should fail
  • after running the approve operations it should succeed
@rob-reynolds rob-reynolds added the bug Something isn't working label Nov 27, 2022
@rob-reynolds rob-reynolds changed the title $ra.resolve should error if the most recent DI aren't status final $ra.resolve should error if approve has not been called first Nov 27, 2022
c-schuler added a commit that referenced this issue Nov 29, 2022
@c-schuler
#670: fixed resolve operation precondition chek and updated tests
0f8a5be
rob-reynolds pushed a commit that referenced this issue Nov 29, 2022
@c-schuler
RA Approve operation implementation (#669)
cffaf59 
* Added Composition.author as a Bundle.entry to prevent error in building IG (document type Bundle requires Composition.author to be an entry)
Added fullUrl values for all Bundle.entry to prevent errors in building IG (document type Bundle requires fullUrl)
Removed http://hl7.org/fhir/us/davinci-ra/StructureDefinition/ra-groupReference extension from the DetectedIssue.detail to prevent errors in building IG (extension not valid for that element)
Updated profile for Composition to match IG

* Updated the id for remediate bundle
Fixed bug with getting remediate issues
Fixed bug where updating the DetectedIssue detail references to remove the group extension was removing the group extension from the MR
Updated DetectedIssue.code to be the HCC code

* Updated report profile to fix errors in IG (the Bundle profile was being used instead of the MR profile)
Added author to Bundle.entry for remediate and resolve to fix errors in IG (Composition.author is required to be in the Bundle when the type is document)
Updated evaluate to use the bundle profile instead of the mr profile

* #662: implemented approve operation logic and tests - fixed build

* Fixing build and tests

* Update tests to account for author Organization

* Add required Composition.author and Organization to fix tests

* Fix error message for missing Composition.author

* Protect the Composition author value

* Added protection for creating fullUrls
Increased test counts to account for updates to RA operations
Added ids to test resources to fix tests

* applied feedback

* applied feedback - fixed tests

* #670: fixed resolve operation precondition chek and updated tests

* Undo unintentional update of launch file

Co-authored-by: rob-reynolds <rob@alphora.com>
@c-schuler c-schuler mentioned this issue Nov 29, 2022
Merged
rob-reynolds pushed a commit that referenced this issue Nov 30, 2022
@c-schuler @JPercival
Resolve and Approve operation implementation (#675)
e6cf0c1 
* #641: added resolve operation, updated constants, updated ra.evaluate-measure operation and tests, updated evidence status date extension

* #641: Added closure request test and fixed MR group update logic

* #641: added invalidation and creation tests

* #641: Added creation error and precondition tests and logic - added ordering to tests and updated dates to ensure the correct bundle is being fetched

* RA Approve operation implementation (#669)

* Added Composition.author as a Bundle.entry to prevent error in building IG (document type Bundle requires Composition.author to be an entry)
Added fullUrl values for all Bundle.entry to prevent errors in building IG (document type Bundle requires fullUrl)
Removed http://hl7.org/fhir/us/davinci-ra/StructureDefinition/ra-groupReference extension from the DetectedIssue.detail to prevent errors in building IG (extension not valid for that element)
Updated profile for Composition to match IG

* Updated the id for remediate bundle
Fixed bug with getting remediate issues
Fixed bug where updating the DetectedIssue detail references to remove the group extension was removing the group extension from the MR
Updated DetectedIssue.code to be the HCC code

* Updated report profile to fix errors in IG (the Bundle profile was being used instead of the MR profile)
Added author to Bundle.entry for remediate and resolve to fix errors in IG (Composition.author is required to be in the Bundle when the type is document)
Updated evaluate to use the bundle profile instead of the mr profile

* #662: implemented approve operation logic and tests - fixed build

* Fixing build and tests

* Update tests to account for author Organization

* Add required Composition.author and Organization to fix tests

* Fix error message for missing Composition.author

* Protect the Composition author value

* Added protection for creating fullUrls
Increased test counts to account for updates to RA operations
Added ids to test resources to fix tests

* applied feedback

* applied feedback - fixed tests

* #670: fixed resolve operation precondition chek and updated tests

* Undo unintentional update of launch file

Co-authored-by: rob-reynolds <rob@alphora.com>

Co-authored-by: Jonathan Percival <jonathan.i.percival@gmail.com>
Co-authored-by: rob-reynolds <rob@alphora.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c-schuler c-schuler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rob-reynolds @c-schuler