Use Node 16/18 and NPM #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafeltra
reviewed
Apr 24, 2023
jafeltra
reviewed
Apr 24, 2023
There was a problem hiding this comment.
This looks good to me. I left one comment that you can take or leave. Besides that, I didn't see anything else in the code.
I'm not sure how strict you tend to be in PR descriptions in this repo, but just so you know, I think you're referring to the wrong npm script in the description:
Make sure you're running Node 18, then run
npm installfollowed bynpm check
should probably be
Make sure you're running Node 18, then run
npm installfollowed bynpm run test:plus
Using npm ci chokes w/ node 14 -- so use npm install. Also update checkout and setup-node actions to use v3.
jafeltra
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes yarn in favor of npm. The
yarn.lockis replaced bypackage-lock.json. The GitHub actions and README have also been updated. In addition, a newtest:plusscript has been added for running tests, lint, and prettier in one shot.To test, pull the branch and delete
node_modules. Make sure you're running Node 18, then runnpm installfollowed bynpm test:plus. Everything should work well. Note that Node 14 and 16 should also work (and are tested in CI), but we avoid them in development since they use a different package-lock format.