Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ensureValueSets and ensureValueSetsInLibrary methods #23

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

cmoesel
Copy link
Member

@cmoesel cmoesel commented Nov 29, 2022

The ensureValueSets and ensureValueSetsInLibrary methods no longer work because VSAC does not support username/password authentication anymore. These were deprecated in later versions of 1.x and are now being removed for version 2.x.

@cmoesel cmoesel requested a review from jafeltra November 29, 2022 20:29
Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I had one minor comment in the README to update if you want.

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cmoesel cmoesel merged commit 10e9e60 into master Nov 30, 2022
@cmoesel cmoesel deleted the remove-deprecated-methods branch November 30, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants