Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendation testing #202

Merged
merged 28 commits into from
Aug 22, 2022
Merged

Recommendation testing #202

merged 28 commits into from
Aug 22, 2022

Conversation

c-schuler
Copy link
Collaborator

@c-schuler c-schuler commented Aug 19, 2022

Added Thunder Client test suite
Updated requests and test narratives
Removed unnecessary bundles
Added commit policy
Added script to refresh test data using the date roller operation
Simplified common cql logic

Copy link
Collaborator

@Capt-Mac Capt-Mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing thunder client had some failures:

  • Rec02- recommendation-tests failed Query: json.cards.length equal to 0 => Actual: 1
  • Rec03- REQUEST_RETURN_NO_RECOMMENDATION: cQuery: json.cards.length equal to 0 => Actual: 1
  • Rec07- REQUEST_RETURN_RECOMMENDATION_7OF10: Query: json.cards[0].summary equal to Patients on opioid therapy should be evaluated for benefits and harms within 1 to 4 weeks of starting opioid therapy and every 3 months or more subsequently. => Actual: undefined
    Fail
    Query: json.cards[0].detail equal to No evaluation for benefits and harms has been performed for the patient starting opioid therapy => Actual: undefined
    Fail
    Query: json.cards[0].indicator equal to warning => Actual: undefined
    Fail
    Query: json.cards[0].suggestions[0].actions[0].resource.resourceType equal to ServiceRequest => Actual: undefined

@Capt-Mac Capt-Mac self-requested a review August 22, 2022 18:29
Copy link
Collaborator

@Capt-Mac Capt-Mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved test errors

Copy link
Contributor

@bryantaustin13 bryantaustin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and ran without error in Thunder test suite.

@bryantaustin13 bryantaustin13 merged commit 4e5710a into master Aug 22, 2022
@bryantaustin13 bryantaustin13 deleted the recommendation-tests branch August 22, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants