Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar header tweaks #4

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Sidebar header tweaks #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions x-pack/plugins/canvas/public/components/sidebar_header/sidebar_header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export class SidebarHeader extends PureComponent {
items: [
{
name: 'Cut',
icon: 'empty', // TODO: need a cut icon
icon: 'cut',
onClick: () => {
closePopover();
cutElements();
Expand Down Expand Up @@ -161,8 +161,8 @@ export class SidebarHeader extends PureComponent {
},
},
{
name: 'Save as custom element',
icon: 'save',
name: 'Save as new element',
icon: 'indexOpen',
className: topBorderClassName,
onClick: () => {
this.showModal();
Expand Down Expand Up @@ -199,17 +199,6 @@ export class SidebarHeader extends PureComponent {
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiFlexGroup alignItems="center" gutterSize="none">
<EuiFlexItem grow={false}>
<EuiToolTip position="bottom" content="Save as custom element">
<EuiButtonIcon
color="text"
iconType="save"
onClick={this.showModal}
aria-label="Save as custom element"
/>
</EuiToolTip>
</EuiFlexItem>
<EuiFlexItem grow={false}>{contextMenu}</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiToolTip position="bottom" content="Move element to top layer">
<EuiButtonIcon
Expand Down Expand Up @@ -250,6 +239,17 @@ export class SidebarHeader extends PureComponent {
/>
</EuiToolTip>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiToolTip position="bottom" content="Save as new element">
<EuiButtonIcon
color="text"
iconType="indexOpen"
onClick={this.showModal}
aria-label="Save as new element"
/>
</EuiToolTip>
</EuiFlexItem>
<EuiFlexItem grow={false}>{contextMenu}</EuiFlexItem>
</EuiFlexGroup>
</EuiFlexItem>
</EuiFlexGroup>
Expand Down