Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions #509

Merged
merged 14 commits into from
May 19, 2024
Merged

Update versions #509

merged 14 commits into from
May 19, 2024

Conversation

sideeffffect
Copy link

No description provided.

@sideeffffect sideeffffect mentioned this pull request May 11, 2024
@sideeffffect
Copy link
Author

@cquiroz 🙏 ☝️

@@ -15,105 +15,87 @@ on:
tags: [v*]

env:
PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be included to do publication I think

echo "$PGP_PASSPHRASE" | gpg --pinentry-mode loopback --passphrase-fd 0 --import /tmp/signing-key.gpg
(echo "$PGP_PASSPHRASE"; echo; echo) | gpg --command-fd 0 --pinentry-mode loopback --change-passphrase $(gpg --list-secret-keys --with-colons 2> /dev/null | grep '^sec:' | cut --delimiter ':' --fields 5 | tail -n 1)

- name: Publish
run: sbt '++ ${{ matrix.scala }}' tlRelease
env:
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see they are defined here


addSbtPlugin("io.github.cquiroz" % "sbt-tzdb" % "4.2.0")

addSbtPlugin("org.typelevel" % "sbt-typelevel" % "0.4.17")
addSbtPlugin("org.typelevel" % "sbt-typelevel-ci-release" % "0.7.1")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks

sbt
@@ -0,0 +1,664 @@
#!/usr/bin/env bash
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you include the sbt script?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macOS image doesn't seem to contain sbt. So we include this bash wrapper script which make sbt startable from anywhere (anywhere bash is).

@cquiroz
Copy link
Owner

cquiroz commented May 17, 2024

Thanks this is great, do you kow why one of the build steps doesn't complete?

@cquiroz cquiroz closed this May 19, 2024
@cquiroz cquiroz reopened this May 19, 2024
@cquiroz cquiroz merged commit db787b1 into cquiroz:master May 19, 2024
21 checks passed
@sideeffffect sideeffffect deleted the update-versions branch May 19, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants