Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notice] Nav2 Migrated to TwistStamped to replace Twist for cmd_vel Topics #908

Open
SteveMacenski opened this issue Dec 3, 2024 · 2 comments

Comments

@SteveMacenski
Copy link
Collaborator

Hi,

As a key community project using Nav2, I wanted to drop you a note that I am in the process of changing the default cmd_vel topic type from Twist to TwistStamped in efforts of enabling a broader set of applications and safety constraints. This has been an on-going discussion over the last 18 months and now has the technology stack in GZ, ROS Control, and Nav2 to enable it.

To migrate, your robot and simulation should soon accept a TwistStamped message rather than a Twist message. We have a couple of provided utilities that could make this easier for you, by switching to use a Twist Publisher and Twist Subscriber [1-2]. This is what is now used in all Nav2 nodes to either publish or subscribe to a Twist or TwistStamped message.

If you would like to continue to use a Twist, you can set enable_stamped_cmd_vel to false in all nodes in your configuration that use Twist Publisher/Subscriber objects, but this will be shortly switched to being default true.

[1] https://github.com/ros-navigation/navigation2/blob/main/nav2_util/include/nav2_util/twist_publisher.hpp
[2] https://github.com/ros-navigation/navigation2/blob/main/nav2_util/include/nav2_util/twist_subscriber.hpp

Nav2 migration:

@SteveMacenski
Copy link
Collaborator Author

SteveMacenski commented Dec 3, 2024

I think it would just be flipping the following line:

stamped_control_ = this->declare_parameter("stamped_control", false);
by default and in the configuration files.

@ayrton04 I can do this -- are you OK with a change of this nature for rolling given no-new-features? With your approval, I'll make the adjustment for ros2 only

@ayrton04
Copy link
Collaborator

ayrton04 commented Dec 4, 2024

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants