Skip to content

bug: call micro_code pop order #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2024
Merged

bug: call micro_code pop order #52

merged 3 commits into from
Apr 17, 2024

Conversation

@wxiaoyun
Copy link
Member

@wxiaoyun wxiaoyun commented Apr 17, 2024 •
edited
Loading

Description

  • At compile time, arguments to function call are pushed onto operand_stack using LDC in order.
  • When running CALL, the popped values are in the reversed order. So CALL instruction need to un-reverse the arguments

Other changes

  • Update CI/CD to run build script

@wxiaoyun wxiaoyun added the bug Something isn't working label Apr 17, 2024
@wxiaoyun wxiaoyun requested a review from leonidas1712 April 17, 2024 01:38
@wxiaoyun wxiaoyun self-assigned this Apr 17, 2024
@wxiaoyun wxiaoyun mentioned this pull request Apr 17, 2024
Merged
14 tasks
@wxiaoyun wxiaoyun enabled auto-merge April 17, 2024 02:26
leonidas1712
leonidas1712 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@leonidas1712 leonidas1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wxiaoyun wxiaoyun merged commit 50776eb into crabscript:master Apr 17, 2024
@wxiaoyun wxiaoyun deleted the vm-fix-call branch April 17, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonidas1712 leonidas1712 leonidas1712 approved these changes

Assignees

@wxiaoyun wxiaoyun

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wxiaoyun @leonidas1712