Disable VT mode if stdout is redirected #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`read_cursor_pos()` sends `"\x1b[6n"` to stdout and then expects to read the cursor position from stdin. This can never work if stdout is not a console, and previously caused MS-DOS Player to hang in an infinite loop in that case. Since `use_vt` is set based on the Windows version and the `-vt` flag merely toggles this default, we also got different behavior depending on the OS: On Windows ≥10, `msdos prog >NUL` would hang and `msdos prog -vt >NUL` would run, but it's the other way around on earlier Windows versions.
nmlgc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_cursor_pos()sends"\x1b[6n"to stdout and then expects to read the cursor position from stdin. This can never work if stdout is not a console, and causes MS-DOS Player to hang in an infinite loop in that case.Since
use_vtis set based on the Windows version and the-vtflag merely toggles this default, we also get different behavior depending on the OS: On Windows ≥10,msdos prog >NULwould hang andmsdos prog -vt >NULwould run, but it's the other way around on earlier Windows versions.