Remove is_drum from _load_instruments

[craffel]

Resolves #86. Now that channel is used as a key for note_on_index and __get_instrument, we no longer need to separately key by is_drum, which is just defined as channel == 9.

@douglaseck can you check to see if this breaks any of your code? There should be no change in behavior here.

[douglaseck]

This seems fine. Please go ahead and submit.

On Thu, Sep 1, 2016 at 3:29 PM, Colin Raffel notifications@github.com
wrote:

Resolves #86 #86. Now that
channel is used as a key for note_on_index and __get_instrument, we no
longer need to separately key by is_drum, which is just defined as channel
== 9.

@douglaseck https://github.com/douglaseck can you check to see if this

breaks any of your code? There should be no change in behavior here.

You can view, comment on, or merge this pull request online at:

#87
Commit Summary

• Remove is_drum from _load_instruments

File Changes

• M pretty_midi/pretty_midi.py
  https://github.com/craffel/pretty-midi/pull/87/files#diff-0 (48)

Patch Links:

• https://github.com/craffel/pretty-midi/pull/87.patch
• https://github.com/craffel/pretty-midi/pull/87.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#87, or mute the thread
https://github.com/notifications/unsubscribe-auth/APQ6QnWAfgj0Tf5uOOozyg4ALoVi90ePks5ql1G7gaJpZM4JzMgn
.

[craffel]

Please go ahead and submit.

Is this a genteel way of saying LGTM? :) Merging.