Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siteName array general config setting not working as expected #2968

Closed
ademers opened this issue Jun 7, 2018 · 0 comments · Fixed by #2969
Closed

siteName array general config setting not working as expected #2968

ademers opened this issue Jun 7, 2018 · 0 comments · Fixed by #2969

Comments

@ademers
Copy link
Contributor

ademers commented Jun 7, 2018

Description

Setting a siteName array in general.php does not work as documented at https://docs.craftcms.com/api/v3/craft-config-generalconfig.html#property-sitename

Steps to reproduce

  1. In general.php add following config setting:
'siteName' => [
    'default' => 'Primary Site',
    'secondary' => 'Secondary Site',
],
  1. Site Names in CP are not overwritten as expected.

The issue appears to be in sites.php line 1039:

cms/src/services/Sites.php

Lines 1039 to 1041 in ebfec3e

if (is_array($generalConfig->siteName) && isset($generalConfig->siteUrl[$site->handle])) {
$site->overrideName($generalConfig->siteUrl[$site->handle]);
}

Additional info

  • Craft version: Craft Pro 3.0.10.1
  • PHP version: 7.0.29
  • Database driver & version: MySQL 5.5.5
  • Plugins & versions: https://cl.ly/0V130W1w2C2B
ademers added a commit to ademers/cms that referenced this issue Jun 7, 2018
@ademers ademers mentioned this issue Jun 7, 2018
brandonkelly added a commit that referenced this issue Jun 7, 2018
brandonkelly added a commit that referenced this issue Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant