Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rel="noopener" for all external links #3201

Closed
XhmikosR opened this issue Aug 14, 2018 · 6 comments
Closed

Add rel="noopener" for all external links #3201

XhmikosR opened this issue Aug 14, 2018 · 6 comments

Comments

@XhmikosR
Copy link
Contributor

References

There are some links dynamically created in JS; those should have it too.

I have a local branch which takes care of this, but since I'm not familiar with the code base I decided not to submit it. If it'll help, I can make a PR, though.

@brandonkelly
Copy link
Member

Craft already sets a referrer policy for all Control Panel pages, so this is not necessary.

<meta name="referrer" content="origin-when-cross-origin">

@XhmikosR
Copy link
Contributor Author

@brandonkelly: this is not related to the referrer. Please read the links above.

@brandonkelly
Copy link
Member

Sorry, misread.

@brandonkelly brandonkelly reopened this Aug 14, 2018
@XhmikosR
Copy link
Contributor Author

Do you want me to push my current PR? Some changes might not be right, but I can rebase after any feedback.

@brandonkelly
Copy link
Member

Sure.

@XhmikosR
Copy link
Contributor Author

Done in #3202.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants