Multi-Matrix block ownership #10577
Merged
Multi-Matrix block ownership #10577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonkelly
force-pushed
the
feature/dev-110-improve-matrix-save-performance
branch
from
c61076a to
4dba6ec
Compare
brandonkelly
deleted the
feature/dev-110-improve-matrix-save-performance
branch
This was referenced Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the ability for a Matrix block to have multiple owners, via a new
matrixblocks_ownersjoin table. This enables a massive performance improvement when creating new drafts: we no longer need to duplicate Matrix blocks for drafts, unless something has actually changed within the block. Instead we can just duplicate the block/owner relation rows.Here’s a look at the performance gains when creating a draft for an entry with 100 blocks and 10 sites:
Similarly, when applying a draft, we no longer need to re-save any blocks that were never touched for the draft. However the improvement isn’t quite as stark there if versioning is enabled for the section, as we still need to duplicate all the blocks when creating the revision.
Related issues