Show error color for product tabs with errors in Matrix fields

Same bug as craftcms/cms#3248
craftcms · Sep 7, 2018 · 0a01c20 · 0a01c20
1 parent d3b0456
commit 0a01c20
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG-v2.md b/CHANGELOG-v2.md
@@ -18,6 +18,7 @@
 - Fixed a bug where order statuses weren’t remembering whether they were the default status. ([#476](https://github.com/craftcms/commerce/issues/476))
 - Fixed a bug where variants with generated SKUs could get incorrect validation errors. ([#451](https://github.com/craftcms/commerce/issues/451))
 - Fixed a bug where order PDF URLs weren’t accessible to customers in some cases.
+- Fixed a bug where Edit Product pages weren’t revealing which tab(s) had errors on it, if the errors occurred within a Matrix field.
 
 ## 2.0.0-beta.8.1 - 2018-08-27
 

diff --git a/src/controllers/ProductsController.php b/src/controllers/ProductsController.php
@@ -361,7 +361,7 @@ private function _prepVariables(array &$variables)
  if ($product->hasErrors()) {
  foreach ($tab->getFields() as $field) {
  /** @var Field $field */
- if ($hasErrors = $product->hasErrors($field->handle)) {
+ if ($hasErrors = $product->hasErrors($field->handle . '.*')) {
  break;
  }
  }