Deprecate email
as an attribute on the Order
element
#3201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently Commerce is needlessly duplicating data into the
email
column for the order element. As all customers are now user elements (either credentialed or inactive) the email for the order can be taken directly from this.This is the first part of a two step process to remove
email
as an actual attribute on theOrder
element. In this step it is simply to tidy up the code around emails and deprecate thesetEmail()
on the element. The second part, likely to be in Commerce 5, will be to remove theemail
column entirely from the orders database table.With
setEmail()
now being deprecated it is advised to switch any code using the method to usesetCustomer
along with theensureUserByEmail()
method from Craft's user service.