Skip to content

Shows product title on variant chip #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
lukeholder wants to merge 8 commits into
base: 5.x
Choose a base branch
from
Draft

Shows product title on variant chip #4178

lukeholder wants to merge 8 commits into from
+27 −1

Conversation

@lukeholder
Copy link
Member

@lukeholder lukeholder commented Nov 12, 2025

Potential fix for #4155

  • Detects when the request originates from Craft Commerce product pages (including AJAX requests) and preserves the simple variant label in those cases.
  • Adds checks to safely return the simple variant label if no owner is set.
  • Maintains proper label order for right-to-left (RTL) locales.

Base automatically changed from 5.5 to 5.x November 18, 2025 16:36
@lukeholder lukeholder mentioned this pull request Dec 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukeholder