Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when importing decimal number which is not present as an xml node #527

Closed
davecoggins opened this issue Apr 28, 2019 · 4 comments
Closed

Comments

@davecoggins
Copy link

Description

After upgrading from feedme 3.0.4 to 4.1 our feed is throwing the following error when importing into a number field with decimal value set to 2:

SQLSTATE[22007]: Invalid datetime format: 1366 Incorrect decimal value: '[]' for column 'field_rent' at row 1

To give a bit more context this is a estate agent website that does both sales and rentals. This is effecting only sales properties. In the XML feed a property that is a sales property doesn't have an xml element for rent.

I currently still have FeedmePro 3.0.4 installed, not sure if this could be effecting things.

Many thanks

Steps to reproduce

  1. Create a feed that has 2 elements, one that has a rent xml node and one that doesn't
  2. Map the rent xml node to a number field with decimal point set to 2

Additional info

  • Plugin version: 4.1
  • Craft version: 3.1.24
@ghost
Copy link

ghost commented May 1, 2019

I am having the same problem. It won't fill a number field because the value is empty.

@davecoggins
Copy link
Author

Hi

I've just updated the site (locally) that was solved by this fix but the bug is now back. As you mention in #4849 would you be able to fix this in the feedme plugin instead?

Many thanks

@davecoggins
Copy link
Author

Hi

Just wondering if anyone has had chance to take a look at this issue?

Many thanks

@brandonkelly
Copy link
Member

Feed Me 4.3.0 is out now with a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants