Csv: Fix unintended cast #1137
Merged
Csv: Fix unintended cast #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
League CSV 9's ResultSet is an object and casting it to an array causes chaotic behavior. Just keep it as mixed.
|
@ishitatsuyuki can you provide a sample feed and some steps to reproduce what you're trying to fix here? Generally speaking, anything that relies on Craft 4 is more strictly typed, not less. |
|
You should be able to reproduce the issue with any CSV, when League CSV 9.8 is used. Observe that the suggested row count is wrong. If that is not sufficient, I used a two-column CSV with headers and 50 rows following that. |
|
Just released 5.0.3 with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
League CSV 9's ResultSet is an object and casting it to an array causes chaotic behavior. Just keep it as mixed.
CSV reader in 5.0 has been consistently malfunctioning in unpredictable ways, e.g. reporting different element count or reporting errors that are not at all helpful.