Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for actually utilising custom Feed Me Data Types. #172

Closed

Conversation

timeverts
Copy link

Josh,

While doing some experimenting with Feed Me, I needed to create a custom data type but then could not work out how I could actually create a feed with that custom data type. There was no built in way to select my custom data type for a new feed even though it was registered using the registerFeedMeDataTypes plugin hook. It would also not be possible to save a new feed with a custom data type, since the feeds record is restricted to your built in types.

So I went about making some changes to properly support custom Feed Me Data Types. Take a look and see what you think.

Note that I added the functionality to allow specifying a different display name for a custom data type so that the default displayed name of MyPlugin_MyCustomFeedMeDataType can be customised.

Let me know if you have any questions or recommendations.

@engram-design
Copy link
Contributor

Thanks for setting this up. There are a few tweaks I might do to this, but for the most part, on the right track. Third-party data types were a bit rushed in the end, and was going to address it properly when someone had the need for it.

I'll hold off on adding this for the moment, to bundle with the next release as it'll change the schema. Thanks!

@engram-design
Copy link
Contributor

engram-design commented Mar 30, 2017

@timeverts Thanks again so much for the PR (not to mention the migration), its now been rolled into 2.0.2 (didn't have to change a thing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants