Returning feedData from beforeProcessFeed() and counting the number of items after, instead of before #619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed changes adds the feed data returned from
EVENT_BEFORE_PROCESS_FEED
to the return array, and counts the number of items afterbeforeProcessFeed()
is called, instead of before. This gives the ability to actually modify the feed data via theEVENT_BEFORE_PROCESS_FEED
event.The change in #462 give the
EVENT_BEFORE_PROCESS_FEED
the ability to change the $feedData in the event. However, as nothing else is happening in thebeforeProcessFeed()
function, and the feed data is not part of the$return
array returned from the function, any changes made to the actual feed data is effectively lost.Furthermore, as the items in the feed data are counted before
beforeProcessFeed()
is called, any changes to the number of items in the feed (e.g. removing duplicates), will give the wrong number of iterations in the queue.