Fix siteId not applied to asset find query #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems after feed-me create an asset, it always find element for primary site id. so if target site Id is not primary site, it add/updates element for wrong site. for example craftcms#658 has same scenario. this PR add siteId of target site to criteria to find correct element record after asset creation.
vnali
changed the title
vnali
changed the title
|
Thanks! |
|
Feed Me 4.3.0 is out now with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems when feed-me create an asset, it always find element for primary site id. so if target site Id is not primary site, it add/updates element for wrong site.
this PR add siteId of target site to criteria to find correct element record after asset creation.
Related issues
for example #658 has same scenario.