Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: enabled and ported tests to xunit #785

Conversation

toore
Copy link
Contributor

@toore toore commented Aug 27, 2022

For confidence and regression matter, I've enabled (uncommented) and ported some tests to xunit. IMHO the tests should be enabled and running (successfully) all the time.

@toore toore changed the title Improvement enabled and ported tests to xunit Improvement: enabled and ported tests to xunit Aug 27, 2022
@toore toore force-pushed the improvement-enabled-and-ported-tests-to-xunit branch from 37d4bf8 to eb46fc2 Compare September 23, 2022 14:21
@toore
Copy link
Contributor Author

toore commented Oct 4, 2022

IMO, I think the failing checks are false positives. Looking at the other PRs, there are more checks in this PR (more targets built).

Is there any possibility to re-trigger this build?

@toore toore force-pushed the improvement-enabled-and-ported-tests-to-xunit branch from eb46fc2 to 7790503 Compare October 6, 2022 19:00
@toore toore force-pushed the improvement-enabled-and-ported-tests-to-xunit branch from 4540afc to 7790503 Compare November 14, 2022 20:27
@toore toore force-pushed the improvement-enabled-and-ported-tests-to-xunit branch from 7790503 to 12f7bc1 Compare November 14, 2022 20:30
@lithiumtoast lithiumtoast merged commit 5595621 into craftworkgames:develop Nov 15, 2022
@toore toore deleted the improvement-enabled-and-ported-tests-to-xunit branch November 16, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants