Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for class (nested) properties #817

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,17 @@ public static class ContentWriterExtensions
// ReSharper disable once SuggestBaseTypeForParameter
public static void WriteTiledMapProperties(this ContentWriter writer, IReadOnlyCollection<TiledMapPropertyContent> value)
{
if (value == null)
{
writer.Write(0);
return;
}
writer.Write(value.Count);
foreach (var property in value)
{
writer.Write(property.Name);
writer.Write(property.Value);
writer.Write(property.Value ?? string.Empty);
WriteTiledMapProperties(writer, property.Properties);
}
}
}
Expand Down
20 changes: 20 additions & 0 deletions src/cs/MonoGame.Extended.Tiled/ContentReaderExtensions.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
using Microsoft.Xna.Framework.Content;

namespace MonoGame.Extended.Tiled
{
public static class ContentReaderExtensions
{
public static void ReadTiledMapProperties(this ContentReader reader, TiledMapProperties properties)
{
var count = reader.ReadInt32();

for (var i = 0; i < count; i++)
{
var key = reader.ReadString();
var value = new TiledMapPropertyValue(reader.ReadString());
ReadTiledMapProperties(reader, value.Properties);
properties[key] = value;
}
}
}
}
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System.Collections.Generic;
using System.Xml.Serialization;

namespace MonoGame.Extended.Tiled.Serialization
Expand All @@ -13,11 +14,15 @@ public class TiledMapPropertyContent
[XmlText]
public string ValueBody { get; set; }

[XmlArray("properties")]
[XmlArrayItem("property")]
public List<TiledMapPropertyContent> Properties { get; set; }

public string Value => ValueAttribute ?? ValueBody;

public override string ToString()
{
return $"{Name}: {Value}";
}
}
}
}
10 changes: 8 additions & 2 deletions src/cs/MonoGame.Extended.Tiled/TiledMapProperties.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@

namespace MonoGame.Extended.Tiled
{
public class TiledMapProperties : Dictionary<string, string>
public class TiledMapProperties : Dictionary<string, TiledMapPropertyValue>
{
public bool TryGetValue(string key, out string value)
{
bool result = TryGetValue(key, out TiledMapPropertyValue tmpVal);
value = result ? null : tmpVal.Value;
return result;
}
}
}
}
32 changes: 32 additions & 0 deletions src/cs/MonoGame.Extended.Tiled/TiledMapPropertyValue.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
namespace MonoGame.Extended.Tiled;

public class TiledMapPropertyValue
{
public string Value { get; }

public TiledMapProperties Properties;

public TiledMapPropertyValue()
{
Value = string.Empty;
Properties = new();
}

public TiledMapPropertyValue(string value)
{
Value = value;
Properties = new();
}

public TiledMapPropertyValue(TiledMapProperties properties)
{
Value = string.Empty;
Properties = properties;
}

public override string ToString() => Value;

//public static implicit operator TiledMapPropertyValue(string value) => new(value);
public static implicit operator string(TiledMapPropertyValue value) => value.Value;
public static implicit operator TiledMapProperties(TiledMapPropertyValue value) => value.Properties;
}
18 changes: 3 additions & 15 deletions src/cs/MonoGame.Extended.Tiled/TiledMapReader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,24 +16,12 @@ protected override TiledMap Read(ContentReader reader, TiledMap existingInstance
return existingInstance;

var map = ReadTiledMap(reader);
ReadProperties(reader, map.Properties);
reader.ReadTiledMapProperties(map.Properties);
ReadTilesets(reader, map);
ReadLayers(reader, map);
return map;
}

private static void ReadProperties(ContentReader reader, TiledMapProperties properties)
{
var count = reader.ReadInt32();

for (var i = 0; i < count; i++)
{
var key = reader.ReadString();
var value = reader.ReadString();
properties[key] = value;
}
}

private static TiledMap ReadTiledMap(ContentReader reader)
{
var name = reader.AssetName;
Expand Down Expand Up @@ -98,7 +86,7 @@ private static TiledMapLayer ReadLayer(ContentReader reader, TiledMap map)
var parallaxFactor = new Vector2(parallaxX, parallaxY);
var properties = new TiledMapProperties();

ReadProperties(reader, properties);
reader.ReadTiledMapProperties(properties);

TiledMapLayer layer;

Expand Down Expand Up @@ -154,7 +142,7 @@ private static TiledMapObject ReadTiledMapObject(ContentReader reader, TiledMap
var properties = new TiledMapProperties();
const float opacity = 1.0f;

ReadProperties(reader, properties);
reader.ReadTiledMapProperties(properties);

TiledMapObject mapObject;

Expand Down
18 changes: 3 additions & 15 deletions src/cs/MonoGame.Extended.Tiled/TiledMapTilesetReader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public static TiledMapTileset ReadTileset(ContentReader reader)
for (var tileIndex = 0; tileIndex < explicitTileCount; tileIndex++)
ReadTile(reader, tileset);

ReadProperties(reader, tileset.Properties);
reader.ReadTiledMapProperties(tileset.Properties);
return tileset;
}

Expand All @@ -53,7 +53,7 @@ private static void ReadTile(ContentReader reader, TiledMapTileset tileset)
: new TiledMapTilesetAnimatedTile(localTileIdentifier,
ReadTiledMapTilesetAnimationFrames(reader, tileset, animationFramesCount), type, objects, texture);

ReadProperties(reader, tilesetTile.Properties);
reader.ReadTiledMapProperties(tilesetTile.Properties);
tileset.Tiles.Add(tilesetTile);
}

Expand Down Expand Up @@ -99,7 +99,7 @@ private static TiledMapObject ReadTiledMapObject(ContentReader reader, TiledMapT
var properties = new TiledMapProperties();
const float opacity = 1.0f;

ReadProperties(reader, properties);
reader.ReadTiledMapProperties(properties);

TiledMapObject mapObject;

Expand Down Expand Up @@ -145,17 +145,5 @@ private static Point2[] ReadPoints(ContentReader reader)

return points;
}

private static void ReadProperties(ContentReader reader, TiledMapProperties properties)
{
var count = reader.ReadInt32();

for (var i = 0; i < count; i++)
{
var key = reader.ReadString();
var value = reader.ReadString();
properties[key] = value;
}
}
}
}