Use actual printer width for elapsed segment instead of fixed width=5 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinosaure
approved these changes
May 26, 2023
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
May 26, 2023
CHANGES: - Fix lower bounds on UTF-8 libraries (@craigfe, 42759d5) - Fix removed functions in `mtime.2.0.0` (@patricoferris, craigfe/progress#31) - Use actual printer width for elapsed segment (@lsdch, craigfe/progress#28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation forces fixed width=5 for elapsed segments, which is not sufficient when using other formats than
mm:sssuch aselapsed ~pp:Progress.Units.Duration.hh_mm_ss ().This made the calculated length for the bar incorrect, and results in unwanted line wraps.
Using the width declared in the printer seems to fix the problem.