Use loop-based DFS to resolve rspec#341 (SystemStackError)

craigjbass · Jan 27, 2018 · dcb4c12 · dcb4c12
1 parent 2f9091b
commit dcb4c12
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/rspec/support/source/node.rb b/lib/rspec/support/source/node.rb
@@ -48,10 +48,15 @@ def location
         def each(&block)
           return to_enum(__method__) unless block_given?
 
-          yield self
+          outstanding_nodes = []
+          outstanding_nodes << self
+          while outstanding_nodes.length > 0
+            current_node = outstanding_nodes.pop
+            current_node.children.each do |node|
+              outstanding_nodes.unshift(node)
+            end
 
-          children.each do |child|
-            child.each(&block)
+            yield current_node
           end
         end