Fixed a ton of bugs an problems encountered by trying to use json4lua #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored rpcserver code Fixed request method checking code Fixed post data retrieving method Added a check to make sure parameters have the proper type Fixed the Content-Type header to better adhere to JSON RPC standards
Refactored the code to use lua-cjson module for JSON encoding and decoding TODO: finalize doc updates
This reverts commit 7b0c126.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm new to Lua. Please be gentle.
I have attempted to use the RPC functionality json4lua module but found that it is completely unusable as is. I have fixed all the problems I have found. Please review.