This repository has been archived by the owner on Oct 30, 2020. It is now read-only.
Response success logic #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tappleby, sorry, I never got a notification for this pull request. Is this good to go? I know the tests are failing, but thats most likely the fault of Moneris and the fact that these tests have to make actual requests to the api, making them super fragile. Notice they are passing now since I ran them one at a time. I changed Travis to limit it to 1 concurrent build at a time so these tests shouldn't be racing against each other anymore. Let me know and I'll merge it. Also, does this require any documentation updates? |
|
Meant to try again, can you try and retigger the Travis CI test for this PR? I think only owners can do it. |
|
@tappleby Ah I did not know that. I triggered the build again and it completed successfully. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we were discussing previously failed CVD / AVS response doesnt necessarily mean the transaction has failed. After fighting with the moneris API more and reviewing some other libraries I believe their might be a bug with the logic for a successful response.
This PR updates the successful flag to only check if the receipt was complete + if the response code is in the range from 0-49 (Financial Response Codes).
The failed AVS + CVD flags are still being set but its up to the merchant to decide how they want to handle these (eg. void purchase in application code, manual process etc).
Some other examples of response handling out in the wild:
I was hoping to add some more functional test for Response but the moneris test APIs like to return odd result later in the day. Will try again in the morning and see what gets returned for the Penny values.