Change bit order of Whirlpool A/C Messages

Analysis of the temperature data in the Whirlpool messages indicate the bytes of data are in LSB First order, not MSB First. See #509 (comment)
crankyoldgit · Sep 2, 2018 · 4c2077d · 4c2077d
1 parent ca80a39
commit 4c2077d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/src/ir_Whirlpool.cpp b/src/ir_Whirlpool.cpp
@@ -56,7 +56,7 @@ void IRsend::sendWhirlpoolAC(unsigned char data[], uint16_t nbytes,
                 kWhirlpoolAcGap,
                 data, 6,  // 6 bytes == 48 bits
                 38000,  // Complete guess of the modulation frequency.
-                true, 0, 50);
+                false, 0, 50);
     // Section 2
     sendGeneric(0, 0,
                 kWhirlpoolAcBitMark, kWhirlpoolAcOneSpace,
@@ -65,15 +65,15 @@ void IRsend::sendWhirlpoolAC(unsigned char data[], uint16_t nbytes,
                 kWhirlpoolAcGap,
                 data + 6, 8,  // 8 bytes == 64 bits
                 38000,  // Complete guess of the modulation frequency.
-                true, 0, 50);
+                false, 0, 50);
     // Section 3
     sendGeneric(0, 0,
                 kWhirlpoolAcBitMark, kWhirlpoolAcOneSpace,
                 kWhirlpoolAcBitMark, kWhirlpoolAcZeroSpace,
                 kWhirlpoolAcBitMark, kWhirlpoolAcMinGap,
                 data + 14, 7,  // 7 bytes == 56 bits
                 38000,  // Complete guess of the modulation frequency.
-                true, 0, 50);
+                false, 0, 50);
   }
 }
 #endif  // SEND_WHIRLPOOL_AC
@@ -128,7 +128,8 @@ bool IRrecv::decodeWhirlpoolAC(decode_results *results, uint16_t nbits,
                               kWhirlpoolAcBitMark,
                               kWhirlpoolAcZeroSpace);
       if (data_result.success == false)  break;  // Fail
-      results->state[i] = (uint8_t) data_result.data;
+      // Data is in LSB order. We need to reverse it.
+      results->state[i] = (uint8_t) reverseBits(data_result.data & 0xFF, 8);
     }
     // Section Footer
     if (!matchMark(results->rawbuf[offset++], kWhirlpoolAcBitMark))

diff --git a/test/ir_Whirlpool_test.cpp b/test/ir_Whirlpool_test.cpp
@@ -13,8 +13,8 @@ TEST(TestSendWhirlpoolAC, SendDataOnly) {
   IRsendTest irsend(0);
   irsend.begin();
   uint8_t data[kWhirlpoolAcStateLength] = {
-      0xC1, 0x60, 0x08, 0x8E, 0x00, 0x00, 0x89, 0xF8, 0x00, 0x00, 0x00, 0x00,
-      0x00, 0xF7, 0x00, 0x40, 0x00, 0x00, 0x00, 0x00, 0x40};
+      0x83, 0x06, 0x10, 0x71, 0x00, 0x00, 0x91, 0x1F, 0x00, 0x00, 0x00, 0x00,
+      0x00, 0xEF, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x02};
 
   irsend.sendWhirlpoolAC(data);
   EXPECT_EQ(
@@ -55,8 +55,8 @@ TEST(TestDecodeWhirlpoolAC, SyntheticDecode) {
   // Synthesised Normal WhirlpoolAC message.
   irsend.reset();
   uint8_t expectedState[kWhirlpoolAcStateLength] = {
-      0xC1, 0x60, 0x08, 0x8E, 0x00, 0x00, 0x89, 0xF8, 0x00, 0x00, 0x00, 0x00,
-      0x00, 0xF7, 0x00, 0x40, 0x00, 0x00, 0x00, 0x00, 0x40};
+      0x83, 0x06, 0x10, 0x71, 0x00, 0x00, 0x91, 0x1F, 0x00, 0x00, 0x00, 0x00,
+      0x00, 0xEF, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x02};
   irsend.sendWhirlpoolAC(expectedState);
   irsend.makeDecodeResult();
   EXPECT_TRUE(irrecv.decode(&irsend.capture));
@@ -103,8 +103,8 @@ TEST(TestDecodeWhirlpoolAC, RealExampleDecode) {
       596, 542,  598, 544,  596, 534,  596, 524,  594, 1644,  596, 532,
       596, 534,  596, 538,  602, 536,  594, 546,  594, 520,  600};
   uint8_t expectedState[kWhirlpoolAcStateLength] = {
-    0xC1, 0x60, 0x08, 0x8E, 0x00, 0x00, 0x89, 0xF8, 0x00, 0x00, 0x00, 0x00,
-    0x00, 0xF7, 0x00, 0x40, 0x00, 0x00, 0x00, 0x00, 0x40};
+      0x83, 0x06, 0x10, 0x71, 0x00, 0x00, 0x91, 0x1F, 0x00, 0x00, 0x00, 0x00,
+      0x00, 0xEF, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x02};
 
   irsend.reset();
   irsend.sendRaw(rawData, 343, 38000);