Skip to content

Commit

Permalink
[SAMSUNG_AC] Highest fan speed is available without Powerful setting.
Browse files Browse the repository at this point in the history
Per user feedback, it seems the highest fan speed is just a normal fan speed, not locked behind `setPowerful(true)` as previous thought.

Fixes #1675
  • Loading branch information
crankyoldgit committed Nov 13, 2021
1 parent a727486 commit c7f897c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
3 changes: 0 additions & 3 deletions src/ir_Samsung.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -644,9 +644,6 @@ void IRSamsungAc::setPowerful(const bool on) {
// Powerful mode sets fan speed to Turbo.
setFan(kSamsungAcFanTurbo);
setQuiet(false); // Powerful 'on' is mutually exclusive to Quiet.
} else {
// Turning off Powerful mode sets fan speed to Auto if we were in Turbo mode
if (_.Fan == kSamsungAcFanTurbo) setFan(kSamsungAcFanAuto);
}
}

Expand Down
1 change: 0 additions & 1 deletion test/ir_Samsung_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,6 @@ TEST(TestIRSamsungAcClass, SetAndGetPowerful) {
EXPECT_EQ(kSamsungAcFanTurbo, ac.getFan());
ac.setPowerful(false);
EXPECT_FALSE(ac.getPowerful());
EXPECT_EQ(kSamsungAcFanAuto, ac.getFan());

// Breeze, Econo, and Powerful/Turbo are mutually exclusive.
ac.setPowerful(true);
Expand Down

0 comments on commit c7f897c

Please sign in to comment.