move SPIFFS to LittleFS for ESP8266 #1226

Caffreyfans · 2020-07-29T12:58:56Z

I only replace SPIFFS.open() and SPIFFS.begin() by LittleFS for ESP8266.

examples/Web-AC-control/Web-AC-control.ino

Caffreyfans · 2020-08-05T01:10:25Z

Why change directory upload to directory data. Please see link below.They can upload by esptool.
uploading-files-to-filesystem

Caffreyfans

No errors found

crankyoldgit · 2020-08-07T00:46:34Z

Why change directory upload to directory data. Please see link below.They can upload by esptool.
uploading-files-to-filesystem

I didn't write the code for Web-AC-control.ino, some other author did. i.e. it was use submitted.
If you want to change it to something more "standard", feel free to.

examples/IRMQTTServer/IRMQTTServer.h

crankyoldgit · 2020-08-07T00:48:56Z

examples/IRMQTTServer/IRMQTTServer.ino

+
+
+


Nitpick: These blank lines can be removed.

Already edited. 👍

crankyoldgit · 2020-08-07T00:53:19Z

examples/IRMQTTServer/IRMQTTServer.ino

 //
 // Returns:
 //   A boolean indicating success or failure.
 bool mountSpiffs(void) {
-  debug("Mounting SPIFFS...");
-  if (SPIFFS.begin()) return true;  // We mounted it okay.
+  debug("Mounting FILESYSTEM...");


debug("Mounting " FILESYSTEM "...");
Use that instead, and it should report if it is SPIFFS or LittleFS etc.

Already change to:

#if (FILESYSTEM == LittleFS) debug("... LittleFS ..."); #else debug("... SPIFSS ..."0; #endif

If you use my suggestion, then you don't need the #if clause and it works for any other type of FS.

crankyoldgit · 2020-08-07T00:53:31Z

examples/IRMQTTServer/IRMQTTServer.ino

+  debug("Failed to mount FILESYSTEM!\n"
+        "Formatting FILESYSTEM and trying again...");


debug("Failed to mount " FILESYSTEM "!\n" "Formatting " FILESYSTEM " and trying again...");

Use that instead, and it should report if it is SPIFFS or LittleFS etc.

crankyoldgit · 2020-08-07T00:53:36Z

examples/IRMQTTServer/IRMQTTServer.ino

+        "Formatting FILESYSTEM and trying again...");
+  FILESYSTEM.format();
+  if (!FILESYSTEM.begin()) {  // Did we fail?
+    debug("DANGER: Failed to mount FILESYSTEM even after formatting!");


debug("DANGER: Failed to mount " FILESYSTEM " even after formatting!");
Use that instead, and it should report if it is SPIFFS or LittleFS etc.

crankyoldgit · 2020-08-07T00:56:53Z

examples/Web-AC-control/Web-AC-control.ino

    //  Open the file
    server.streamFile(file, contentType);
    //  Send it to the client
    file.close();
    // Close the file again
-    // Serial.println(String("\tSent file: ") + path);
+    Serial.println(String("\tSent file: ") + path);


Ditto. You're changing the behaviour by adding in the debug messages. Is that something you mean to do?

re-comment.

crankyoldgit · 2020-08-07T00:57:03Z

examples/Web-AC-control/Web-AC-control.ino

    return true;
  }
-  // Serial.println(String("\tFile Not Found: ") + path);
+  Serial.println(String("\tFile Not Found: ") + path);


re-comment.

crankyoldgit · 2020-08-07T00:57:23Z

examples/Web-AC-control/Web-AC-control.ino

-      // Serial.print("handleFileUpload Size: ");
-      // Serial.println(upload.totalSize);
+      Serial.print("handleFileUpload Size: ");
+      Serial.println(upload.totalSize);


re-comment.

crankyoldgit · 2020-08-07T00:57:39Z

examples/Web-AC-control/Web-AC-control.ino

-  // Serial.begin(115200);
-  // Serial.println();
+  Serial.begin(115200);
+  Serial.println();
  ac.begin();


re-comment.

crankyoldgit · 2020-08-07T00:57:50Z

examples/Web-AC-control/Web-AC-control.ino

-  // Serial.println("mounting FS...");
+  Serial.println("mounting FS...");


re-comment.

Doesn't appear to have been updated.

did you git push?

examples/IRMQTTServer/IRMQTTServer.ino

examples/IRMQTTServer/IRMQTTServer.h

crankyoldgit

LGTM

_v2.7.10 (20200831)_ **[BREAKING CHANGES]** - move SPIFFS to LittleFS for ESP8266 (#1182 #1226) - Daikin176: Change & increase operating mode values. (#1233 #1235) **[Bug Fixes]** - TOSHIBA_AC: not turning off when using `IRac` class. (#1250 #1251) - Haier: change position of Fan speed bits. (#1246 #1247) **[Features]** - Voltas: Add detailed support for Voltas A/Cs (#1238 #1248) - Add support for Metz protocol. (#1241 #1242) - Basic support for Voltas A/C protocol (#1238 #1243) - Add low level bit formatting sanity checks. (#1232) **[Misc]** - Rewrite Airwell by using bit fields (#1254) - Rewrite Haier YRW02 using bit fields (#1253) - rewrite Haier HSU07-HEA03 (#1246 #1247) - rewrite ir_Gree & ir_Midea by using bit field (#1240) - Incorrect usage of `assert()` (#1244 #1245 #1232) - rewrite Gree (#1210)

## v2.7.10 release _v2.7.10 (20200831)_ **[BREAKING CHANGES]** - move SPIFFS to LittleFS for ESP8266 (#1182 #1226) - Daikin176: Change & increase operating mode values. (#1233 #1235) **[Bug Fixes]** - TOSHIBA_AC: not turning off when using `IRac` class. (#1250 #1251) - Haier: change position of Fan speed bits. (#1246 #1247) **[Features]** - Voltas: Add detailed support for Voltas A/Cs (#1238 #1248) - Add support for Metz protocol. (#1241 #1242) - Basic support for Voltas A/C protocol (#1238 #1243) - Add low level bit formatting sanity checks. (#1232) **[Misc]** - Rewrite Airwell by using bit fields (#1254) - Rewrite Haier YRW02 using bit fields (#1253) - rewrite Haier HSU07-HEA03 (#1246 #1247) - rewrite ir_Gree & ir_Midea by using bit field (#1240) - Incorrect usage of `assert()` (#1244 #1245 #1232) - rewrite Gree (#1210)

crankyoldgit · 2020-08-31T14:15:22Z

The code changes mention have now been included in the newly released v2.7.10 of the library.

sblantipodi · 2020-08-31T14:25:24Z

thanks for your work here @crankyoldgit
why this change is marked as breaking changes?

what should I do before upgrading to 2.7.10?
thanks
Davide

crankyoldgit · 2020-08-31T14:42:35Z

It's only a breaking change for two of the code examples. IRMQTTServer and Web-AC-Control.

For those two examples, LittleFS is enabled as a (default) replacement/alternative to SPIFFS for the local file system on ESP8266s.
You can choose SPIFFS as the default to retain backward compatiblity.
See:

IRremoteESP8266/examples/IRMQTTServer/IRMQTTServer.h

Lines 35 to 48 in 87d448f

    
           // Uncomment one of the following to manually override what 
        
           //    type of persistent storage is used. 
        
           // Warning: Changing filesystems will cause all previous locally 
        
           //    saved configuration data to be lost. 
        
           // #define FILESYSTEM SPIFFS 
        
           // #define FILESYSTEM LittleFS 
        
           #ifndef FILESYSTEM 
        
           // Set the default filesystem if none was specified. 
        
           #ifdef ESP8266 
        
           #define FILESYSTEM LittleFS 
        
           #else 
        
           #define FILESYSTEM SPIFFS 
        
           #endif  // defined(ESP8266) 
        
           #endif  // FILESYSTEM

If you choose to use LittleFS instead of SPIFFS it will wipe any locally stored information in the local filesystem of the ESP chip.
e.g. Config file for IRMQTTServer and uploaded (web) files for Web-AC-Control

SPIFFS is now deprecated in the ESP8266 Core library due to it no longer being maintained AFAIK, LittleFS is a drop-in replacement, but completely different format, so it will format the data partition on first use.

So, what do you need to do? Backup/record any config/settings and be prepared to have to do the initial setup of any ESP running IRMQTTServer, and re-upload any files you uploaded to Web-AC-Control

crankyoldgit · 2020-08-31T15:00:50Z

I've made this (I hope) clearer (scope-wise) in the ReleaseNotes.md file, and on the page for the v2.7.10 release pointing to your/this question etc.

sblantipodi · 2020-08-31T15:43:15Z

ok thanks for the answer 👍

move SPIFFS to LittleFS for ESP8266

3fe412d

crankyoldgit requested review from crankyoldgit and NiKiZe July 30, 2020 02:32

crankyoldgit assigned crankyoldgit and NiKiZe Jul 30, 2020

crankyoldgit added the enhancement label Jul 30, 2020

ymiao and others added 6 commits July 31, 2020 10:17

add FILESYSTEM warning

97762ec

make lines <= 80 characters long

b5f6241

make lines <= 80 characters long

40da907

Merge remote-tracking branch 'upstream/master'

5884f62

no message

73013c3

no message

4a9f8e1

crankyoldgit requested changes Aug 3, 2020

View reviewed changes

examples/Web-AC-control/Web-AC-control.ino Outdated Show resolved Hide resolved

Caffreyfans added 6 commits August 4, 2020 20:06

Move SPIFFS to LittleFS for ESP8266(#1182)

7a6b70c

[fix]: wrong format

1da5816

[fix]: fix error format

361b152

[fix] fix error format

2228f4b

[Change]: change FILE_SYSTEM to FILESYSTEM

6976880

Add WiFiManager

fec76d3

Caffreyfans requested a review from crankyoldgit August 5, 2020 01:03

Caffreyfans commented Aug 5, 2020

View reviewed changes

crankyoldgit requested changes Aug 7, 2020

View reviewed changes

Report if it is SPIFFS or LittleFS

102596e

crankyoldgit reviewed Aug 7, 2020

View reviewed changes

examples/IRMQTTServer/IRMQTTServer.ino Outdated Show resolved Hide resolved

Caffreyfans added 3 commits August 11, 2020 19:25

Reduces code duplication

685450d

Fix format error

e2f5327

Fix format error

178ae10

crankyoldgit reviewed Aug 12, 2020

View reviewed changes

examples/IRMQTTServer/IRMQTTServer.h Show resolved Hide resolved

crankyoldgit approved these changes Aug 12, 2020

View reviewed changes

crankyoldgit merged commit a6cd2ac into crankyoldgit:master Aug 12, 2020

crankyoldgit mentioned this pull request Aug 31, 2020

v2.7.10 Release #1257

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move SPIFFS to LittleFS for ESP8266 #1226

move SPIFFS to LittleFS for ESP8266 #1226

Caffreyfans commented Jul 29, 2020

Caffreyfans commented Aug 5, 2020

Caffreyfans left a comment

crankyoldgit commented Aug 7, 2020

crankyoldgit Aug 7, 2020

Caffreyfans Aug 7, 2020

crankyoldgit Aug 7, 2020

Caffreyfans Aug 7, 2020

crankyoldgit Aug 7, 2020

crankyoldgit Aug 7, 2020

Caffreyfans Aug 7, 2020

crankyoldgit Aug 7, 2020

Caffreyfans Aug 7, 2020

crankyoldgit Aug 7, 2020

Caffreyfans Aug 7, 2020

crankyoldgit Aug 7, 2020

Caffreyfans Aug 7, 2020

crankyoldgit Aug 7, 2020

Caffreyfans Aug 7, 2020

crankyoldgit Aug 7, 2020

Caffreyfans Aug 7, 2020

crankyoldgit Aug 7, 2020

Caffreyfans Aug 7, 2020

crankyoldgit Aug 7, 2020

crankyoldgit Aug 7, 2020

crankyoldgit left a comment

crankyoldgit commented Aug 31, 2020

sblantipodi commented Aug 31, 2020

crankyoldgit commented Aug 31, 2020

crankyoldgit commented Aug 31, 2020

sblantipodi commented Aug 31, 2020

		debug("Failed to mount FILESYSTEM!\n"
		"Formatting FILESYSTEM and trying again...");

		// Serial.println("mounting FS...");
		Serial.println("mounting FS...");

move SPIFFS to LittleFS for ESP8266 #1226

move SPIFFS to LittleFS for ESP8266 #1226

Conversation

Caffreyfans commented Jul 29, 2020

Caffreyfans commented Aug 5, 2020

Caffreyfans left a comment

Choose a reason for hiding this comment

crankyoldgit commented Aug 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crankyoldgit left a comment

Choose a reason for hiding this comment

crankyoldgit commented Aug 31, 2020

sblantipodi commented Aug 31, 2020

crankyoldgit commented Aug 31, 2020

crankyoldgit commented Aug 31, 2020

sblantipodi commented Aug 31, 2020