-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fujitsu: Add support for ARREW4E
model.
#1456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `setId()` & `getId()` for controlling multiple A/C units in the same area. * Add/update unit tests. Ref: #1455
* Wrong bit location. * Add unit test data for known different ID. Ref #1455
* Use `matchGeneric()` where we can. * Change the data header check to allow for different device IDs. * Add check to Unit tests & minor clean up. For #1455
* Add unit test (poor signal) For #1455
* Add experimental support for Fahrenheit too. For #1455
* Allow Powerful & Economy settings. * Add draft swing settings display/control (To be verified) * Update unit tests. For #1455
Update unit tests as well For #1455
* Allow OutsideQuiet codes to be built for ARREW4E. For #1455
* Add `set10CHeat()` & `get10CHeat()` * Limit native Fahrenheit support to ARREW4E only until we work out how it works for other models. * Add & update unit tests. For #1455
* Add Model to list that has the last byte inverted. * Unit tests to make sure it doesn't happen again. * Fix a typo Ref: #1455 (comment)
* Data from the original remote indicates we need to set the fan to auto & turn off swing to properly enter 10 Dec Heat mode. * Unit test coverage. For #1455 (comment)
caspChristian
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in review
NiKiZe
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And that review was done with the wrong account, here is one from the correct one :D
Confirmed working in #1455 (comment) |
crankyoldgit
added a commit
that referenced
this pull request
Apr 17, 2021
_v2.7.17 (20210418)_ **[News]** - The library now supports 100 IR protocols! \o/ **[Bug Fixes]** - Fix `IRAcUtils::decodeToState()` for different length Samsung msgs (#1447 #1448) **[Features]** - Fujitsu: Add support for `ARREW4E` model. (#1455 #1456) - Experimental detailed support for Truma A/Cs. (#1440 #1449) **[Misc]** - Fix Arduino library linter issues. (#1451 #1452 #1453 #1460)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Apr 18, 2021
## _v2.7.17 (20210418)_ ### **[News]** - The library now supports 100 IR protocols! \o/ **[Bug Fixes]** - Fix `IRAcUtils::decodeToState()` for different length Samsung msgs (#1447 #1448) **[Features]** - Fujitsu: Add support for `ARREW4E` model. (#1455 #1456) - Experimental detailed support for Truma A/Cs. (#1440 #1449) **[Misc]** - Fix Arduino library linter issues. (#1451 #1452 #1453 #1460)
crankyoldgit
added a commit
that referenced
this pull request
Apr 19, 2021
_v2.7.17 (20210420)_ **[News]** - The library now supports 100 IR protocols! \o/ **[Bug Fixes]** - Fix `IRAcUtils::decodeToState()` for different length Samsung msgs (#1447 #1448) - Fix issues with installing the library under the Arduino IDE on Win10 & OSX (#1451 #1464) **[Features]** - Fujitsu: Add support for `ARREW4E` model. (#1455 #1456) - Experimental detailed support for Truma A/Cs. (#1440 #1449) **[Misc]** - Fix Arduino library linter issues. (#1451 #1452 #1453 #1460) - Reduce the library's zip download size. (#1451 #1463) - An experiment in using Github Actions to do some of the CI work. (#1462)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setId()
&getId()
for controlling multiple A/C units in the same area. (IRFujitsuAC
class only)decodeFujitsu()
to match different IDs.decodeFujitsu()
to improve matching.ARREW4E
models25.5
IRFujitsuAC
class only)IRtext.h
Fixes #1455