Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fujitsu: Add support for ARREW4E model. #1456

Merged
merged 14 commits into from
Apr 17, 2021
Merged

Fujitsu: Add support for ARREW4E model. #1456

merged 14 commits into from
Apr 17, 2021

Conversation

crankyoldgit
Copy link
Owner

@crankyoldgit crankyoldgit commented Apr 11, 2021

  • All Models:
    • Add setId() & getId() for controlling multiple A/C units in the same area. (IRFujitsuAC class only)
    • Relax tests in decodeFujitsu() to match different IDs.
    • Tweak timing tolerance for decodeFujitsu() to improve matching.
  • ARREW4E models
    • Support new temperature setting style.
      • Half degrees (Celsius) e.g. 25.5
      • Native Fahrenheit support.
      • Allow Outside Quiet, Powerful, & Economy settings.
      • Add support for 10C Heat setting. (IRFujitsuAC class only)
  • Improve header messages in generated IRtext.h

Fixes #1455

* Add `setId()` & `getId()` for controlling multiple A/C units in the same area.
* Add/update unit tests.

Ref: #1455
* Wrong bit location.
* Add unit test data for known different ID.

Ref #1455
* Use `matchGeneric()` where we can.
* Change the data header check to allow for different device IDs.
* Add check to Unit tests & minor clean up.

For #1455
* Add unit test (poor signal)

For #1455
* Add experimental support for Fahrenheit too.

For #1455
* Allow Powerful & Economy settings.
* Add draft swing settings display/control (To be verified)
* Update unit tests.

For #1455
Update unit tests as well

For #1455
* Allow OutsideQuiet codes to be built for ARREW4E.

For #1455
* Add `set10CHeat()` & `get10CHeat()`
* Limit native Fahrenheit support to ARREW4E only until we work out how it works for other models.
* Add & update unit tests.

For #1455
* Add Model to list that has the last byte inverted.
* Unit tests to make sure it doesn't happen again.
* Fix a typo

Ref: #1455 (comment)
* Data from the original remote indicates we need to set the fan to auto & turn off swing to properly enter 10 Dec Heat mode.
* Unit test coverage.

For #1455 (comment)
Copy link

@caspChristian caspChristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in review

src/ir_Fujitsu.cpp Show resolved Hide resolved
test/ir_Fujitsu_test.cpp Show resolved Hide resolved
Copy link
Collaborator

@NiKiZe NiKiZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And that review was done with the wrong account, here is one from the correct one :D

@crankyoldgit
Copy link
Owner Author

Confirmed working in #1455 (comment)

@crankyoldgit crankyoldgit merged commit 635ec85 into master Apr 17, 2021
crankyoldgit added a commit that referenced this pull request Apr 17, 2021
_v2.7.17 (20210418)_
**[News]**
- The library now supports 100 IR protocols! \o/

**[Bug Fixes]**
- Fix `IRAcUtils::decodeToState()` for different length Samsung msgs (#1447 #1448)

**[Features]**
- Fujitsu: Add support for `ARREW4E` model. (#1455 #1456)
- Experimental detailed support for Truma A/Cs. (#1440 #1449)

**[Misc]**
- Fix Arduino library linter issues. (#1451 #1452 #1453 #1460)
@crankyoldgit crankyoldgit mentioned this pull request Apr 17, 2021
@crankyoldgit crankyoldgit deleted the AR-REW4E branch April 18, 2021 02:58
crankyoldgit added a commit that referenced this pull request Apr 18, 2021
## _v2.7.17 (20210418)_
### **[News]**
- The library now supports 100 IR protocols! \o/

**[Bug Fixes]**
- Fix `IRAcUtils::decodeToState()` for different length Samsung msgs (#1447 #1448)

**[Features]**
- Fujitsu: Add support for `ARREW4E` model. (#1455 #1456)
- Experimental detailed support for Truma A/Cs. (#1440 #1449)

**[Misc]**
- Fix Arduino library linter issues. (#1451 #1452 #1453 #1460)
crankyoldgit added a commit that referenced this pull request Apr 19, 2021
_v2.7.17 (20210420)_
**[News]**
- The library now supports 100 IR protocols! \o/

**[Bug Fixes]**
- Fix `IRAcUtils::decodeToState()` for different length Samsung msgs (#1447 #1448)
- Fix issues with installing the library under the Arduino IDE on Win10 & OSX (#1451 #1464)

**[Features]**
- Fujitsu: Add support for `ARREW4E` model. (#1455 #1456)
- Experimental detailed support for Truma A/Cs. (#1440 #1449)

**[Misc]**
- Fix Arduino library linter issues. (#1451 #1452 #1453 #1460)
- Reduce the library's zip download size. (#1451 #1463)
- An experiment in using Github Actions to do some of the CI work. (#1462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Fujitsu Remote AR-REW4E Unit: ASYG09KETA-B
3 participants