Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MitsubishiAC: Fix code lint issue. #1576

Merged
merged 1 commit into from
Aug 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ir_Mitsubishi.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,7 @@ void IRMitsubishiAC::setMode(const uint8_t mode) {
}

/// Set the requested vane (Vertical Swing) operation mode of the a/c unit.
/// @note On some models, this represents the Right vertical vane.
/// @param[in] position The position/mode to set the vane to.
void IRMitsubishiAC::setVane(const uint8_t position) {
uint8_t pos = std::min(position, kMitsubishiAcVaneAutoMove); // bounds check
Expand All @@ -469,6 +470,7 @@ void IRMitsubishiAC::setWideVane(const uint8_t position) {
}

/// Get the Vane (Vertical Swing) mode of the A/C.
/// @note On some models, this represents the Right vertical vane.
/// @return The native position/mode setting.
uint8_t IRMitsubishiAC::getVane(void) const {
return _.Vane;
Expand Down
2 changes: 1 addition & 1 deletion src/ir_Mitsubishi.h
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ union Mitsubishi144Protocol{
uint8_t :8;
// Byte 16
uint8_t :3;
uint8_t VaneLeft :3; // SwingV(Left)
uint8_t VaneLeft :3; // SwingV(Left)
uint8_t :2;
// Byte 17
uint8_t Sum :8;
Expand Down
1 change: 1 addition & 0 deletions test/ir_Mitsubishi_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -725,6 +725,7 @@ TEST(TestMitsubishiACClass, MessageConstuction) {
EXPECT_EQ(kMitsubishiAcCool, ac.getMode());
EXPECT_EQ(27, ac.getTemp());
EXPECT_EQ(3, ac.getVane());
EXPECT_EQ(2, ac.getVaneLeft());
EXPECT_TRUE(ac.getPower());

irsend.reset();
Expand Down