Fix pin number in Daikin example

[quozl]

src/main.cpp:33:22: error: 'D2' was not declared in this scope
IRDaikinESP daikinir(D2);  // An IR LED is controlled by GPIO pin 4 (D2)
                     ^

Compiled on PlatformIO 3.4.1, tested on an Adafruit Feather Huzzah, with correct response from a Daikin A/C.

Note: also occurs in TurnOnKelvinatorAC.ino, TurnOnMitsubishiAC.ino, TurnOnToshibaAC.ino, and TurnOnTrotecAC.ino but I'm unable to test them. 😁 Is the change correct, and shall I widen the change to cover these?

[crankyoldgit]

According to https://github.com/esp8266/Arduino/blob/master/variants/nodemcu/pins_arduino.h#L42
static const uint8_t D2 = 4;
i.e. D2, as printed on the silkscreen on the board) is pin 4 technically.

If we are going to change it, we need to set it to 4 or change the comment to D4 if we change the value to 2.

However, I'm more worried why your platformio environment isn't picking up the D4 constant from the above mentioned file. I didn't have trouble compiling them the last time I tried on a Atom/PlatformIO config on a linux machine. (I didn't get that error) I wonder if it is something odd with the feather/huzzah board setup. If so, we should probably change it to something that works for everything.

[quozl]

Interesting, thanks. Yes, it was the board setup. D2 is a nodemcu-specific pin designator, perhaps considered an extension to Arduino.

My platformio.ini had

[env:huzzah]
platform = espressif8266
board = huzzah
framework = arduino

~/.platformio/packages/framework-arduinoespressif8266/variants/adafruit/pins_arduino.h doesn't have what the nodemcu path has.

Changing platformio.ini to board = nodemcu fixes the compile error.

Pin marking silkscreen on the Feather Huzzah is 2, and is GPIO2 on schematic, from pin 11 of ESP-12, and it does toggle properly.

I guess it wasn't clear from TurnOnArduinoAC.ino that it was nodemcu-specific. 😁

Happy for you to close if you are targeting nodemcu boards only.

For interest, I'm building on Ubuntu 16.04.

[crankyoldgit]

Adafruit are the ones being a bit a-typical. Referring to pins via their labels is supported on traditional Arduino boards for seemingly ever. e.g. Uno, Leonardo, etc.

That said, lets try to make this work for everyone.

In https://github.com/markszabo/IRremoteESP8266/blob/master/examples/IRsendDemo/IRsendDemo.ino#L36
We use just 4. Let's change all of them to be the same 4 on all the "sending" examples.

We can either drop any mention of D2 or expand the comment(s) to say 4 is D2 on NodeMCU/Wemos D1s etc, and 4 on Feathers/Huzzahs etc.

[quozl]

I've just checked, and Arduino IDE with an Uno doesn't accept int led = D13;.

Otherwise, what you propose sounds fine. a4c16ce.

[crankyoldgit]

LGTM