Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to decode ProntoHex #388

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Added support to decode ProntoHex #388

merged 1 commit into from
Jan 9, 2018

Conversation

jorgecis
Copy link
Contributor

@jorgecis jorgecis commented Jan 7, 2018

Change to the gc_decode to allow decode Prontohex codes, here is an example

./gc_decode -prontohex -raw "0000 0068 0000 000D 0060 0018 0018 0018 0018 0018 0018 0018 0018 0018 0030 0018 0018 0018 0018 0018 0030 0018 0018 0018 0018 0018 0018 0018 0018 0438"
Code length 30
Code type 4 (SONY)
Code bits 12
Code value 0x90
Code address 0x1
Code command 0x10
uint16_t rawbuf[26] = {
2400, 600, 600, 600, 600, 600, 600, 600,
600, 600, 1200, 600, 600, 600, 600, 600,
1200, 600, 600, 600, 600, 600, 600, 600,
600, 27000};

Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Minor nitpick: You should probably rename it from gc_decode.cpp to something more generic now. ;-)

@jorgecis
Copy link
Contributor Author

jorgecis commented Jan 8, 2018

Yes, I know but I didn't get a good name for it

@crankyoldgit
Copy link
Owner

@jorgecis I've approved it. Let me know if you can't merge this now. If not, I'll do it for you. (i.e. I can't remember if "approved" gives people permission to merge/submit or not.)

@crankyoldgit
Copy link
Owner

I couldn't come up with a good name either. So, it can stay what it is for now. ;-)

@crankyoldgit crankyoldgit self-assigned this Jan 8, 2018
@crankyoldgit crankyoldgit merged commit 5a1a348 into crankyoldgit:master Jan 9, 2018
@crankyoldgit crankyoldgit mentioned this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants