Fix integer underflow in sendJVC(). #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `sendJVC()` was updated to use `sendGeneric()` it has produced a double minimum gap at the end of each message, instead of a single one. This wasn't picked up by our unit-testing. This tickled a situation where an integer underflow happened when calculating the required `space()` length, which would cause a delay of approx 1h20m. Refactored code to eliminate this problem, and a potential similar case in `sendWhynter()` too. This is a derivative of the bug/issue #381 This instance was reported in #400, which this patch should fix.
|
FYI @schelm87 |
roidayan
approved these changes
Jan 26, 2018
|
Hey @roidayan Thanks for the prompt review! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
sendJVC()was updated to usesendGeneric()it has effectively produced a doubleminimum gap at the end of each message, instead of a single one.
This wasn't picked up by our unit-testing.
This tickled a situation where an integer underflow happened when calculating
the required
space()length, which would cause a delay of approx 1h20m.Refactored code to eliminate this problem, and a potential similar case
in
sendWhynter()too.This is a derivative of the bug/issue #381
This instance was reported in #400, which this patch should fix.