Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct min repeat wrong macro assignment for GICABLE #494

Merged
merged 1 commit into from
Jul 22, 2018

Conversation

1technophile
Copy link
Contributor

GICABLE "repeat" was assigned to GICABLE_BITS instead of GICABLE_MIN_REPEAT

GICABLE "repeat" was assigned to GICABLE_BITS instead of GICABLE_MIN_REPEAT
@crankyoldgit crankyoldgit self-requested a review July 22, 2018 23:50
@crankyoldgit crankyoldgit self-assigned this Jul 22, 2018
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well spotted! Thanks.

@crankyoldgit crankyoldgit merged commit d247706 into crankyoldgit:master Jul 22, 2018
@1technophile
Copy link
Contributor Author

A drop in the ocean ; -) thanks for maintaining this nice library

@crankyoldgit
Copy link
Owner

No worries. Don't belittle your contribution. Everything you find is something I don't have to fix or haven't found etc. Every little bit matters.

@crankyoldgit crankyoldgit mentioned this pull request Jul 26, 2018
crankyoldgit added a commit that referenced this pull request Jul 27, 2018
## _v2.4.3 (20180727)_

**[Bug Fixes]**
- Handle Space Gaps better in auto analyse tool. (#482)
- Correct min repeat for GICABLE in IRMQTTServer. (#494)

**[Features]**
- Add static IP config option to IRMQTTServer (#480)
- Full decoding/encoding support for the Haier YRW02 A/C. (#485 #486 #487)

**[Misc]**
- Update LG (28-bit) HDR mark and space timings. (#492)
- Spelling and grammar fixes (#491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants