Experimental support for Panasonic A/C messages. #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sendPanasonicAC(), decodePanasonicAC(), & IRPanasonicAc class added. * Unit tests for those. * Code HEAVILY influenced by the work done at: https://github.com/ToniA/ESPEasy/blob/HeatpumpIR/lib/HeatpumpIR/PanasonicHeatpumpIR.cpp * Should support LKE/DKE/JKE/NKE series units. * Updated example code as required. Ref: #525
* Panasonic has a Fan mode that requires the temp to be 27C. * Some code lint improvements. * Detail models supported etc. Ref #525
|
FYI, @pandemixxx has confirmed decoding seems to be working fine on a real device. Waiting on feedback for sending. |
seancaulfield
pushed a commit
to seancaulfield/IRremoteESP8266
that referenced
this pull request
Sep 30, 2018
RAWTICK is deprecated. However some users may have used this #define in their code, so adding an alias to the new name will help some user projects compile. Ref: crankyoldgit#535
|
@pandemixxx has confirmed |
markszabo
approved these changes
Oct 1, 2018
* Make the class remember the set temp, so Fan mode doesn't overwrite it. * Adjust unit tests to cover that. * Update unit test Makefile to include protocol header files for dependencies. Ref: #525 (comment)
crankyoldgit
added a commit
that referenced
this pull request
Oct 2, 2018
**[Bug Fixes]** - Correct the byte used for Samsung AC Swing. (#529) - Fix not sending Samsung A/C messages in IRMQTTServer. (#529) **[Features]** - Experimental support for Electra A/C messages. (#528) - Samsung A/C fixes & improvements (#529) - IRMQTTServer v0.6.0 (#530) **[Misc]** - Change required WifiManager lib version to v0.14 - Add alias for RAWTICK to kRawTick. (#535) - Update sendLutron() status. (#515) - Remove leftover debug message in IRrecvDumpV2 (#526)
crankyoldgit
added a commit
that referenced
this pull request
Oct 2, 2018
**[Bug Fixes]** - Correct the byte used for Samsung AC Swing. (#529) - Fix not sending Samsung A/C messages in IRMQTTServer. (#529) **[Features]** - Experimental support for Electra A/C messages. (#528) - Experimental support for Panasonic A/C messages. (#535) - Samsung A/C fixes & improvements (#529) - IRMQTTServer v0.6.0 (#530) **[Misc]** - Change required WifiManager lib version to v0.14 - Add alias for RAWTICK to kRawTick. (#535) - Update sendLutron() status. (#515) - Remove leftover debug message in IRrecvDumpV2 (#526)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Oct 2, 2018
**[Bug Fixes]** - Correct the byte used for Samsung AC Swing. (#529) - Fix not sending Samsung A/C messages in IRMQTTServer. (#529) **[Features]** - Experimental support for Electra A/C messages. (#528) - Experimental support for Panasonic A/C messages. (#535) - Samsung A/C fixes & improvements (#529) - IRMQTTServer v0.6.0 (#530) **[Misc]** - Change required WifiManager lib version to v0.14 - Add alias for RAWTICK to kRawTick. (#535) - Update sendLutron() status. (#515) - Remove leftover debug message in IRrecvDumpV2 (#526)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ToniA/ESPEasy/blob/HeatpumpIR/lib/HeatpumpIR/PanasonicHeatpumpIR.cpp
Ref: #525