Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental timer/clock support for Panasonic A/Cs. #546

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Experimental timer/clock support for Panasonic A/Cs. #546

merged 1 commit into from
Oct 11, 2018

Conversation

crankyoldgit
Copy link
Owner

  • Clock, On Timer, & Off Timer methods for the IRPanasonicAc class.
  • Unit tests for those.
  • Change SetSwingV() -> SetSwingVertical()
  • Change SetSwingH() -> SetSwingHorizontal()

Ref: #544

@crankyoldgit
Experimental timer/clock support for Panasonic A/Cs.
d3a90dc 
- Clock, On Timer, & Off Timer methods for the IRPanasonicAc class.
- Unit tests for those.
- Change SetSwingV() -> SetSwingVertical()
- Change SetSwingH() -> SetSwingHorizontal()

Ref: 544
@crankyoldgit crankyoldgit self-assigned this Oct 4, 2018
@crankyoldgit crankyoldgit requested a review from markszabo October 4, 2018 08:16
@crankyoldgit crankyoldgit added the Hacktoberfest Hacktoberfest participation label Oct 4, 2018
@crankyoldgit
Copy link
Owner Author

No negative review comments after a week. Merging.

@crankyoldgit crankyoldgit merged commit 9aaa511 into master Oct 11, 2018
@crankyoldgit crankyoldgit deleted the panasonic-timers branch October 14, 2018 21:33
crankyoldgit added a commit that referenced this pull request Oct 21, 2018
@crankyoldgit
v2.5.2 release
e0bc8b3 
**[Bug Fixes]**
- Add missing send() method to IRPanasonicAC class. (#545)
- Add missing sendWhirlpoolAC() to IRMQTTServer.ino (#558)

**[Features]**
- Add IR receiving support to IRMQTTServer. (#543)
- Pioneer support (#547)
- Add support for a second LG protocol variant. (#552)
- Support for short Panasonic A/C messages. (#553)
- Add support for Panasonic CKP series A/Cs. (#554)
- Experimental timer/clock support for Panasonic A/Cs. (#546)
- Add Made With Magic (MWM) support (#557)

**[Misc]**
- Grammar and typo fixes (#541, #549)
- Increase Panasonic A/C message tolerances. (#542)
- Added command mode2_decode in tools/ (#557)
- General code style cleanup (#560)
@crankyoldgit crankyoldgit mentioned this pull request Oct 21, 2018
Merged
crankyoldgit added a commit that referenced this pull request Oct 21, 2018
@crankyoldgit
v2.5.2 release (#561)
d58ee79 
**[Bug Fixes]**
- Add missing send() method to IRPanasonicAC class. (#545)
- Add missing sendWhirlpoolAC() to IRMQTTServer.ino (#558)

**[Features]**
- Add IR receiving support to IRMQTTServer. (#543)
- Pioneer support (#547)
- Add support for a second LG protocol variant. (#552)
- Support for short Panasonic A/C messages. (#553)
- Add support for Panasonic CKP series A/Cs. (#554)
- Experimental timer/clock support for Panasonic A/Cs. (#546)
- Add Made With Magic (MWM) support (#557)

**[Misc]**
- Grammar and typo fixes (#541, #549)
- Increase Panasonic A/C message tolerances. (#542)
- Added command mode2_decode in tools/ (#557)
- General code style cleanup (#560)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markszabo markszabo Awaiting requested review from markszabo

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement Hacktoberfest Hacktoberfest participation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crankyoldgit