Add option for RX pin pullup and send whole buffer for received raw messages in IRMQTTServer.ino #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crankyoldgit
requested changes
Dec 28, 2018
There was a problem hiding this comment.
Nice changes. Great idea. Thanks for the contribution.
Just a few nitpicks/suggestions (see review comments) and, the Travis Build seems to have had an intermittent failure. Can you please go here and restart it?
https://travis-ci.org/markszabo/IRremoteESP8266/builds/472783248 We need to have it pass successfully before we can merge etc.
Add comments to increase MQTT_MAX_PACKET_SIZE. Fix using the enum value for UNKNOWN type.
Try to fix some travis issues. - Upgrade to newer arduino package. - Breaking changes because of esp8266 core v2.5 - CpuFrequency -> xtal - FlashSize -> eesz
|
Please update/rebase/pull etc to include PR #591 as it will fix the travis issue. |
Add comments to increase MQTT_MAX_PACKET_SIZE. Fix using the enum value for UNKNOWN type.
matgoebl
commented
Dec 28, 2018
crankyoldgit
requested changes
Dec 29, 2018
matgoebl
commented
Dec 29, 2018
crankyoldgit
approved these changes
Dec 30, 2018
crankyoldgit
added a commit
that referenced
this pull request
Jan 2, 2019
**[Features]** - Experimental basic support for 39 Byte Daikin A/C (#583) - Handle send() repeats in A/C classes. Improve Coolix support. (#580) - Add optional RX pin pullup and dump raw messages in IRMQTTServer.ino (#589) **[Misc]** - Handle send() repeats in A/C classes. Improve Coolix support. (#580) - Update CI/travis config due to esp8266 core 2.5.0 changes (#591)
crankyoldgit
added a commit
that referenced
this pull request
Jan 2, 2019
**[Features]** - Experimental basic support for 39 Byte Daikin A/C (#583) - Handle send() repeats in A/C classes. Improve Coolix support. (#580) - Add optional RX pin pullup and dump raw messages in IRMQTTServer.ino (#589) **[Misc]** - Make auto_analyse_raw_data.py work with Python3 (#581) - Update CI/travis config due to esp8266 core 2.5.0 changes (#591)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Jan 2, 2019
**[Features]** - Experimental basic support for 39 Byte Daikin A/C (#583) - Handle send() repeats in A/C classes. Improve Coolix support. (#580) - Add optional RX pin pullup and dump raw messages in IRMQTTServer.ino (#589) **[Misc]** - Make auto_analyse_raw_data.py work with Python3 (#581) - Update CI/travis config due to esp8266 core 2.5.0 changes (#591)
|
FYI, this has been included in the new v2.5.4 release of the library. |
Repository owner
locked as resolved and limited conversation to collaborators
Jan 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little improvements to IRMQTTServer.ino