Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for the ESP32 architecture & boards. #742

Merged
merged 16 commits into from
Jun 16, 2019
Merged

Initial support for the ESP32 architecture & boards. #742

merged 16 commits into from
Jun 16, 2019

Conversation

crankyoldgit
Copy link
Owner

Similar send & receive functionality as the ESP8266 platform.
i.e. It bit-bangs a software PWM signal when sending IR messages.

  • Tested on a GOOUUU-ESP32 development board, and on ESP8266 boards (d1_mini, nodemcuv2)
  • IRrecvDumpV2 and IRMQTTServer examples appear to work as expected.
  • IRMQTTServer example code requires the development version of the WifiManager library.
  • All examples build successfully on ESP32. Not all of them have been tested.
  • Full platformio support and platformio.inis for each example added. Everything automatically builds out of the box under PlatformIO.
  • Reduce some of the ESP8266-isms and references in the library as it now also supports ESP32.
  • Improvements to how IRMQTTServer handles first boot and/or corrupted SPIFFS situations.

If you have an ESP32 board, please test this an let us know if there are any issues.

@crankyoldgit crankyoldgit self-assigned this Jun 9, 2019
@crankyoldgit
Experimental support for the ESP32 architecture.
b8d311f
@crankyoldgit
Some style and comment cleanup.
c0fa222
@crankyoldgit
Fix some linter and compiler warnings.
b68ac18
@crankyoldgit
Make IRGCTCPServer.ino examplecode work on ESP32
dddd76a
@crankyoldgit
Update IRServer.ino example to work with ESP32
bd8927b
@crankyoldgit
Make IRMQTTServer compatible with ESP32.
43769c6 
- Fix issue with first boot on new hardware that doesn't have a SPIFFS filesystem.
- Ensure the hard wipe/reset creates a SPIFFS fs.
@crankyoldgit
Remove some ESP8266-isms.
e38e891
@crankyoldgit
Make mounting SPIFFS more reliable and verbose.
26415f1
@crankyoldgit
Check Serial RX ping on ESP32s.
850d9ea 
We can't disable the RX pin usage like on the ESP8266, so add it to the check.
@crankyoldgit
Misc text updates for ESP32
56a184b
@crankyoldgit
Handle diff CPU frequencies for kPeriodOffset.
ed176df 
Report the CPU clock freq in the Info page on IRMQTTServer.
@crankyoldgit
Add ESP32 platformio build env for DumbIRRepeater
bd6da41
@crankyoldgit
Fix linter issue.
4b1b838
@crankyoldgit
Mark linter issue as a false positive.
fc5c23a
@crankyoldgit
Move kCommandDelimiter out of MQTT_ENABLE block.
21f4738 
`kCommandDelimiter` isn't just used by MQTT.
@crankyoldgit
Cleanup after master merge.
79f894e
@u4mzu4
Copy link

u4mzu4 commented Jun 13, 2019

Hello!
Have you ever thought about RMT instead of SW PMW?
https://docs.espressif.com/projects/esp-idf/en/latest/api-reference/peripherals/rmt.html
Or does this modification need much more effort as the expected benefit?

@crankyoldgit
Copy link
Owner Author

@u4mzu4 I've started looking at HW PWM on the ESP32, but using the existing code base (software pwm) means I know it just works. Just getting something working out first is the priority. i.e. baby steps. :-) I'll certainly look into the rmt stuff, I didn't know it even existed.

When researching PWM for the ESP32 the other night, I only saw the ledc stuff. I don't have an oscilloscope so I can't verify the duty-cycle stuff myself. If you have access to an oscilloscope, an ESP32, and are willing to do some testing for me, we can explore those avenues sooner rather than later.

@crankyoldgit
Copy link
Owner Author

@u4mzu4 Btw, did you try it out?

@rahuljawale
Copy link
Collaborator

Lot of commits!! Will work on review during this weekend!

@crankyoldgit
Copy link
Owner Author

@rahuljawale That would be great. Any of the open PR that you can review would be fantastic!

@u4mzu4
Copy link

u4mzu4 commented Jun 13, 2019

Hi again!
1.) ESP32 test:
I have this board with bulit-in IR led (GPIO12) and receiver (GPIO39) as well:
https://www.olimex.com/Products/IoT/ESP32/ESP32-EVB/open-source-hardware
(Un)fortunately I'm on holiday, but surely I'm looking forward to testing it sometime after 24.06.
2.) RMT:
I'm just browsing this library, which seems quite rudimentary (by comparison), but uses RMT.
https://github.com/haxplore/ESP32_RMT_IRLib
Otherwise, the SW PMW solution is great enough, there are plenty of resources on ESP32. :-)
Moreover, oscilloscope and ESP32 are available, will see how can fight further.

@crankyoldgit
Copy link
Owner Author

@u4mzu4 Excellent. Hit me up via an Issue when you get back and we can try to work together to make it more hardware based on the ESP32.

@crankyoldgit
Copy link
Owner Author

Merging after 7 days of no "review" feedback.

@crankyoldgit crankyoldgit merged commit f2f1e53 into crankyoldgit:master Jun 16, 2019
crankyoldgit added a commit that referenced this pull request Jun 16, 2019
@crankyoldgit
v2.6.2 release
54020e7 
_v2.6.2 (20190616)_

**[Features]**
- Initial support for the ESP32 architecture & boards. (#742)
- Add changable GPIO settings to IRMQTTServer. (#730)
- IRMQTTServer: Enforce a repeat for all Coolix calls (#752)
- Basic DAIKIN 160bit send and decode. (#754)
- Add example code for a Smart(er) IR Repeater. (#740)
- Enforce Samsung A/C Quiet & Powerful mutual exclusivity.

**[Misc]**
- IRMQTTServer: Add some memory alloc safety checks. (#749)
- Move some ToString() functions to IRac.cpp (#748)
- Increase tolerance value for TCL112AC protocol. (#745)
- Fix compiler warning in IRutils_test.cpp (#756)
- Scrape Supported Protocols and generate SupportedProtocols.md (#755)
- Make supported device info more organised. (#753)
@crankyoldgit crankyoldgit mentioned this pull request Jun 16, 2019
Merged
crankyoldgit added a commit that referenced this pull request Jun 16, 2019
@crankyoldgit
v2.6.2 release (#759)
4af3126 
_v2.6.2 (20190616)_

**[Features]**
- Initial support for the ESP32 architecture & boards. (#742)
- Add changable GPIO settings to IRMQTTServer. (#730)
- IRMQTTServer: Enforce a repeat for all Coolix calls (#752)
- Basic DAIKIN 160bit send and decode. (#754)
- Add example code for a Smart(er) IR Repeater. (#740)
- Enforce Samsung A/C Quiet & Powerful mutual exclusivity.

**[Misc]**
- IRMQTTServer: Add some memory alloc safety checks. (#749)
- Move some ToString() functions to IRac.cpp (#748)
- Increase tolerance value for TCL112AC protocol. (#745)
- Fix compiler warning in IRutils_test.cpp (#756)
- Scrape Supported Protocols and generate SupportedProtocols.md (#755)
- Make supported device info more organised. (#753)
@1technophile
Copy link
Contributor

Woww, thanks for this PR. I will certainly test it in the coming weeks !

@u4mzu4
Copy link

u4mzu4 commented Jun 21, 2019

@crankyoldgit
Short status report:
Sending on ESP32 is working properly, however I've some challenge with signal reception on pin 39
(with IRrecvDumpV2).

@crankyoldgit crankyoldgit deleted the esp32-dev branch June 22, 2019 05:38
@crankyoldgit
Copy link
Owner Author

@u4mzu4 Please log an issue.

However, doing some quick research: https://randomnerdtutorials.com/esp32-pinout-reference-gpios/

GPIOs 34 to 39 are GPIs – input only pins. These pins don’t have internal pull-ups or pull-down resistors. They can’t be used as outputs, so use these pins only as inputs:

No idea if you need to use a pull up/down resistor or not for your module. If it works on other GPIOs, then it could be the issue. Seems some boards use those GPIs for other purposes, so your mileage may vary. :-/

@iotappstory iotappstory mentioned this pull request Oct 9, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwarden bwarden Awaiting requested review from bwarden

@roidayan roidayan Awaiting requested review from roidayan

@sillyfrog sillyfrog Awaiting requested review from sillyfrog

@rahuljawale rahuljawale Awaiting requested review from rahuljawale

@darshkpatel darshkpatel Awaiting requested review from darshkpatel

@markszabo markszabo Awaiting requested review from markszabo

@pintomax pintomax Awaiting requested review from pintomax

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crankyoldgit @u4mzu4 @rahuljawale @1technophile