Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ChalkConfig #330

Merged
merged 4 commits into from
Jun 18, 2024
Merged

refactor: remove ChalkConfig #330

merged 4 commits into from
Jun 18, 2024

Conversation

ee7
Copy link
Contributor

@ee7 ee7 commented Jun 11, 2024

Issue

#214

Description

Continue from #235, #236, #237, and #329, removing the last usage of the autogenerated types: ChalkConfig.

In particular, this PR removes from the confload module's loadLocalStructs() procedure:

chalkConfig = state.attrs.loadChalkConfig()

but deliberately makes only minimal changes there otherwise for now, so that these PRs are tightly focused. That is, all the addCallback(loadLocalStructs) calls still exist for now, but they do less.

After this PR, it's easy to remove c4autoconf itself.

With this PR:

$ git log -1 --format='%h %s'
de237f0 refactor: remove chalkConfig
$ git grep --ignore-case 'chalkConfig'
src/configs/chalk.c42spec:2647:  gen_typename: "ChalkConfig"

@ee7 ee7 mentioned this pull request Jun 11, 2024
4 tasks
@ee7 ee7 marked this pull request as ready for review June 11, 2024 21:45
@ee7 ee7 requested a review from viega as a code owner June 11, 2024 21:45
@ee7 ee7 requested a review from miki725 June 11, 2024 21:45
Base automatically changed from ee7/avoid-c4autoconf-part4 to main June 17, 2024 19:06
@ee7 ee7 force-pushed the ee7/avoid-c4autoconf-part5 branch from 9c11a8a to de237f0 Compare June 17, 2024 19:16
@ee7 ee7 merged commit 9df364b into main Jun 18, 2024
4 checks passed
@ee7 ee7 deleted the ee7/avoid-c4autoconf-part5 branch June 18, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants