-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove most getChalkScope
#395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And for now, inline the use of sectionExists in sinks.nim that wasn't necessarily from the top-level.
Keep reducing use of `getChalkScope()` at call sites.
ee7
force-pushed
the
ee7/reduce-getChalkScope
branch
from
August 5, 2024 18:05
83f46b2
to
bf939c0
Compare
miki725
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
if necessaryDescription
Previous refactoring (most recently 6ce7679) worked towards making nearly every get/set occur from the top level. Refactor so that helper procs always get/set from the top level, so that we no longer write
getChalkScope()
when getting/setting or similar.Before this PR, there was a lot of
getChalkScope()
noise:With this PR, the remaining
getChalkScope()
outsiderun_management.nim
are mostly nil comparisons:Refs: #269
Testing
Verify that this is refactoring only.
The below line enables slow tests for this PR:
tests:--slow