fix nil pointer derefs on bad permissions and add contributing.md #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nettrino
force-pushed
the
nettrino/nilderefs
branch
from
c00e74d to
5c5e9c9
Compare
nettrino
force-pushed
the
nettrino/nilderefs
branch
from
5c5e9c9 to
08c5afe
Compare
miki725
approved these changes
Oct 20, 2022
Comment on lines
+30
to
+33
| 1. When filing a bug or request, please check existing issues to see if there | ||
| exist some issue capturing the same topic already. | ||
|
|
||
| 1. When filing bugs, please provide as detailed steps of reproduction as possible. |
There was a problem hiding this comment.
should we create github issue template with these?
There was a problem hiding this comment.
Yeah no harm doing so
| 1. The current license will remain, and we might introduce a requirement for | ||
| contributors to sign a CLA once the project matures. | ||
|
|
||
| ### Sample Workflow |
There was a problem hiding this comment.
very similar flow documented in here as well https://docs.github.com/en/get-started/quickstart/contributing-to-projects (except pre-commit bits)
There was a problem hiding this comment.
I used cobra as a reference which follows the standard pattern
Comment on lines
+112
to
+116
| log.Logger.Debugf( | ||
| "It appears the token being used doesn't have access to call %v", | ||
| runtime.FuncForPC(reflect.ValueOf(githubCall).Pointer()). | ||
| Name(), | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.