Skip to content

Commit

Permalink
Merge pull request #122 from crashmax-dev/fix/svelte-build-warning
Browse files Browse the repository at this point in the history
fix(svelte): warning on build
  • Loading branch information
crashmax-dev authored Jul 13, 2024
2 parents 8c15ac0 + 58a7199 commit d649a75
Show file tree
Hide file tree
Showing 5 changed files with 9,012 additions and 9,660 deletions.
12 changes: 6 additions & 6 deletions examples/with-svelte/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@
},
"dependencies": {
"@fireworks-js/svelte": "workspace:*",
"svelte": "3.50.1"
"svelte": "4.2.18"
},
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "1.0.8",
"@tsconfig/svelte": "3.0.0",
"svelte-check": "2.9.1",
"svelte-preprocess": "4.10.7",
"typescript": "4.8.4"
"@sveltejs/vite-plugin-svelte": "3.1.1",
"@tsconfig/svelte": "5.0.4",
"svelte-check": "3.8.4",
"svelte-preprocess": "6.0.2",
"typescript": "5.5.3"
}
}
3 changes: 1 addition & 2 deletions examples/with-svelte/src/App.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<script lang="ts">
import { Fireworks } from '@fireworks-js/svelte'
import type { FireworksOptions } from '@fireworks-js/svelte'
import { Fireworks, type FireworksOptions } from '@fireworks-js/svelte'
import { onMount } from 'svelte'
let fw: Fireworks
Expand Down
2 changes: 1 addition & 1 deletion examples/with-svelte/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import App from './App.svelte'

const app = new App({
target: document.getElementById('app')
target: document.querySelector('#app')!
})

export default app
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"description": "A simple fireworks library!",
"homepage": "https://fireworks.js.org",
"packageManager": "pnpm@8.0.0",
"packageManager": "pnpm@9.5.0",
"workspaces": [
"packages/*",
"examples/*",
Expand Down
Loading

0 comments on commit d649a75

Please sign in to comment.