Layered config support #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we'll load from all config sources, merging the result. Fixes crate-ci#93
Not supporting `workspace_root/Cargo.toml` since a comment states it is deprecated.
epage
commented
May 8, 2019
| OsStr::new("NEW_VERSION") => new_version_string.as_ref(), | ||
| OsStr::new("DRY_RUN") => OsStr::new(if dry_run { "true" } else { "false" }), | ||
| OsStr::new("WORKSPACE_ROOT") => ws_meta.workspace_root.as_os_str(), | ||
| OsStr::new("CRATE_ROOT") => manifest_path.parent().unwrap_or_else(|| Path::new(".")).as_os_str(), |
There was a problem hiding this comment.
I need to add some tests to make sure this actually is useful for the various use cases.
I suspect it won't be and that we'll need to do replacements on the hook to allow it to be shared.
I decided against tracking the directory that defines the hook and setting the CWD to simplify the merging process.
epage
commented
May 8, 2019
epage
commented
May 8, 2019
This was referenced May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes loading a workspace-wide config. To make hooks still work, this also adds environment variables to access the workspace and crate paths.
Fixes #93