feat: check all autosquash messages #395
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
For myself, I don't think I'd consider this a major breaking change. Its a minor breaking change that expands functionality to cover cases that either didn't exist or were unknown at the time of creation. |
|
I would have considered this to be a breaking change, but if you don't, you should then use a squash-and-rebase instead of a merge. This way, you can ensure the commit message is exactly as you want. |
|
This is blocked on CI. Since you have to edit this anyways, please remove |
Expand the autosquash prefixes from just `fixup!` to now include `squash!` and `amend!`. These are the prefixes supported by default when using [Git's `--autosquash`](https://git-scm.com/docs/git-rebase#Documentation/git-rebase.txt---autosquash). Signed-off-by: JP-Ellis <josh@jpellis.me>
Head branch was pushed to by a user without write access
JP-Ellis
force-pushed
the
feat/autosquash
branch
from
4e3d3f9
to
b458f39
Compare
|
As requested I have removed the breaking change exclamation from the commit message. I do not know if CI is fixed yet though. |
| @@ -63,7 +63,7 @@ pub(crate) enum Content<'s> { | |||
| NoPunctuation(NoPunctuation), | |||
| Imperative(Imperative<'s>), | |||
| Wip(Wip), | |||
| Fixup(Fixup), | |||
| Autosquash(Autosquash), | |||
There was a problem hiding this comment.
This change is unrelated to this commit and is a breaking change as discussed on the other PRs
There was a problem hiding this comment.
To be clear, my expectation is this commit will continue to emit Fixup
|
Looks like |
Pull Request Test Coverage Report for Build 10949763923Details
💛 - Coveralls |
epage
changed the title
Expand the autosquash prefixes from just
fixup!to now includesquash!andamend!. These are the prefixes supported by default when using Git's--autosquash.To keep the commits atomic as requested in #394, this commit only changes the functionality, while leaving the configuration as is (thereby creating an mismatch between the config naming, and resulting behaviour)